linux-kernel - Re: [PATCH v3 net-next] net: ethernet: mtk_ppe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fe6509ab-c186-47c1-b004-4e17a875c5c7@gmail.com>
Date: Wed, 12 Feb 2025 20:33:52 +0100
From: Eric Woudstra <ericwouds@...il.com>
To: Jakub Kicinski <kuba@...nel.org>,
 Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
Cc: Felix Fietkau <nbd@....name>, Sean Wang <sean.wang@...iatek.com>,
 Lorenzo Bianconi <lorenzo@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Frank Wunderlich <frank-w@...lic-files.de>,
 Daniel Golle <daniel@...rotopia.org>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v3 net-next] net: ethernet: mtk_ppe_offload: Allow QinQ

On 2/12/25 1:51 AM, Jakub Kicinski wrote:
> On Sun,  9 Feb 2025 12:09:36 +0100 Eric Woudstra wrote:
>> This patch adds QinQ support to mtk_flow_offload_replace().
>>
>> Only PPPoE-in-Q (as before) and Q-in-Q are allowed. A combination
>> of PPPoE and Q-in-Q is not allowed.
> 
> AFAIU the standard asks for outer tag in Q-in-Q to be ETH_P_8021AD,
> but you still check:
> 
>> 			    act->vlan.proto != htons(ETH_P_8021Q))
>> 				return -EOPNOTSUPP;
> 
> If this is a HW limitation I think you should document that more
> clearly in the commit message. If you can fix it, I think you should..

It will be the first case. mtk_foe_entry_set_vlan() is limited to using
only 1 fixed protocol. I'll drop the reviewed-by, amend the commit
message and send v4.