linux-kernel - Re: [PATCH] wifi: brcmfmac: keep power during suspend if board requires it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8d5ae153-24fb-44bf-89a9-e366e0f205f3@broadcom.com>
Date: Wed, 12 Feb 2025 21:07:10 +0100
From: Arend van Spriel <arend.vanspriel@...adcom.com>
To: Matthias Proske <email@...thias-proske.de>, Kalle Valo
 <kvalo@...nel.org>, Norbert van Bolhuis <nvbolhuis@...il.com>,
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Ondrej Jirman <megi@....cz>, Erick Archer <erick.archer@...look.com>,
 Jacobe Zang <jacobe.zang@...ion.com>
Cc: linux-wireless@...r.kernel.org, brcm80211@...ts.linux.dev,
 brcm80211-dev-list.pdl@...adcom.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wifi: brcmfmac: keep power during suspend if board
 requires it

On 2/12/2025 7:59 PM, Matthias Proske wrote:
> After commit 92cadedd9d5f ("brcmfmac: Avoid keeping power to SDIO card
> unless WOWL is used"), the wifi adapter by default is turned off on
> suspend and then re-probed on resume.
> 
> This conflicts with some embedded boards that require to remain powered.
> They will fail on resume with:
> 
> brcmfmac: brcmf_sdio_bus_rxctl: resumed on timeout
> ieee80211 phy1: brcmf_bus_started: failed: -110
> ieee80211 phy1: brcmf_attach: dongle is not responding: err=-110
> brcmfmac: brcmf_sdio_firmware_callback: brcmf_attach failed
> 
> This commit checks for the Device Tree property 'cap-power-off-cards'.
> If this property is not set, it means that we do not have the capability
> to power off and should therefore remain powered.

Thanks! Looks good to me.

Acked-by: Arend van Spriel <arend.vanspriel@...adcom.com>
> Signed-off-by: Matthias Proske <email@...thias-proske.de>
> ---
>   .../broadcom/brcm80211/brcmfmac/bcmsdh.c      | 20 ++++++++++++-------
>   1 file changed, 13 insertions(+), 7 deletions(-)