linux-kernel - Re: [PATCH 1/4] media: dt-bindings: Add Sony IMX728

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ab2394be-fe1c-46c1-9940-53b4ee1afc5b@linaro.org>
Date: Wed, 12 Feb 2025 21:07:57 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Sebastian LaVine <slavine@...mbedded.com>, devicetree@...r.kernel.org,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, linux-media@...r.kernel.org
Cc: Nícolas F. R. A. Prado <nfraprado@...labora.com>,
 Abel Vesa <abel.vesa@...aro.org>, Achath Vaishnav <vaishnav.a@...com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Ard Biesheuvel <ardb@...nel.org>,
 Benjamin Mugnier <benjamin.mugnier@...s.st.com>,
 Biju Das <biju.das.jz@...renesas.com>,
 Bjorn Andersson <quic_bjorande@...cinc.com>,
 Catalin Marinas <catalin.marinas@....com>, Conor Dooley
 <conor+dt@...nel.org>, Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
 Elinor Montmasson <elinor.montmasson@...oirfairelinux.com>,
 Fabio Estevam <festevam@...il.com>,
 Geert Uytterhoeven <geert+renesas@...der.be>,
 Hans Verkuil <hverkuil@...all.nl>,
 Javier Carrasco <javier.carrasco@...fvision.net>, Jianzhong Xu <xuj@...com>,
 Julien Massot <julien.massot@...labora.com>,
 Kieran Bingham <kieran.bingham@...asonboard.com>,
 Kory Maincent <kory.maincent@...tlin.com>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Mikhail Rudenko <mike.rudenko@...il.com>, Nishanth Menon <nm@...com>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Rob Herring <robh@...nel.org>, Sakari Ailus <sakari.ailus@...ux.intel.com>,
 Sascha Hauer <s.hauer@...gutronix.de>, Shawn Guo <shawnguo@...nel.org>,
 Stuart Burtner <sburtner@...mbedded.com>, Tero Kristo <kristo@...nel.org>,
 Thakkar Devarsh <devarsht@...com>,
 Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
 Umang Jain <umang.jain@...asonboard.com>,
 Vignesh Raghavendra <vigneshr@...com>, Will Deacon <will@...nel.org>,
 Zhi Mao <zhi.mao@...iatek.com>
Subject: Re: [PATCH 1/4] media: dt-bindings: Add Sony IMX728

On 12/02/2025 20:56, Sebastian LaVine wrote:
> +
> +  reset-gpios:
> +    maxItems: 1
> +    description:
> +      Specifier for the GPIO connected to the XCLR (System Reset) pin.

s/Specifier for the GPIO connected to the//
But you could say that it is active low, for example.

> +
> +  error0-gpios:
> +    maxItems: 1
> +    description:
> +      Specifier for the GPIO connected to the XWRN pin.

The same.

> +
> +  error1-gpios:
> +    maxItems: 1
> +    description:
> +      Specifier for the GPIO connected to the XERR pin.
> +
> +  port:
> +    $ref: /schemas/graph.yaml#/properties/port
> +    additionalProperties: false
> +
> +    properties:
> +      endpoint:
> +        $ref: ../video-interfaces.yaml#
> +        unevaluatedProperties: false
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +  - port
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    i2c {
> +        clock-frequency = <400000>;

Drop, not really relevant.

> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        camera@1a {
> +            compatible = "sony,imx728";
> +            reg = <0x1a>;
> +
> +            clocks = <&fixed_clock>;
> +            clock-names = "inck";
> +
> +            reset-gpios = <&gpio4 17 GPIO_ACTIVE_LOW>;
> +            error0-gpios = <&sens_exp 1 GPIO_ACTIVE_HIGH>;
> +            error1-gpios = <&sens_exp 2 GPIO_ACTIVE_HIGH>;
> +
> +            port {
> +                camera1: endpoint {
> +                    remote-endpoint = <&vin1a_ep>;
> +                };
> +            };
> +        };
> +    };
> +
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 575f0e6f0532..50bff3558d7d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -21885,6 +21885,12 @@ T:     git git://linuxtv.org/media.git
>  F:     Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
>  F:     drivers/media/i2c/imx415.c
> 
> +SONY IMX728 SENSOR DRIVER
> +M:     Stuart Burtner <sburtner@...mbedded.com>
> +L:     linux-media@...r.kernel.org
> +S:     Odd Fixes

Hm, why only odd fixes? If you don't care about driver, we also kind of
might not care and remove it soon.

> +F:     Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml
> +
>  SONY MEMORYSTICK SUBSYSTEM
>  M:     Maxim Levitsky <maximlevitsky@...il.com>
>  M:     Alex Dubov <oakad@...oo.com>
> --
> 2.34.1
> 
> Please be aware that this email includes email addresses outside of the organization.

Obviously. Please drop it. You can use b4 relay if you need to escape
corporate junk.

Best regards,
Krzysztof