linux-kernel - RE: [PATCH next 1/1] RDMA/mana_ib: implement reg_user_mr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SA6PR21MB423131E4D0225E43AB27E01ACEFC2@SA6PR21MB4231.namprd21.prod.outlook.com>
Date: Wed, 12 Feb 2025 20:20:40 +0000
From: Long Li <longli@...rosoft.com>
To: Konstantin Taranov <kotaranov@...ux.microsoft.com>, Konstantin Taranov
	<kotaranov@...rosoft.com>, Shiraz Saleem <shirazsaleem@...rosoft.com>,
	"sharmaajay@...rosoft.com" <sharmaajay@...rosoft.com>, "jgg@...pe.ca"
	<jgg@...pe.ca>, "leon@...nel.org" <leon@...nel.org>
CC: "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH next 1/1] RDMA/mana_ib: implement reg_user_mr_dmabuf

> Subject: [PATCH next 1/1] RDMA/mana_ib: implement reg_user_mr_dmabuf
> 
> From: Konstantin Taranov <kotaranov@...rosoft.com>
> 
> Add support of dmabuf MRs to mana_ib.
> 
> Signed-off-by: Konstantin Taranov <kotaranov@...rosoft.com>

Reviewed-by: Long Li <longli@...rosoft.com>

> ---
>  drivers/infiniband/hw/mana/device.c  |  1 +
> drivers/infiniband/hw/mana/mana_ib.h |  4 ++
>  drivers/infiniband/hw/mana/mr.c      | 77 ++++++++++++++++++++++++++++
>  3 files changed, 82 insertions(+)
> 
> diff --git a/drivers/infiniband/hw/mana/device.c
> b/drivers/infiniband/hw/mana/device.c
> index cb8941a..34973ca 100644
> --- a/drivers/infiniband/hw/mana/device.c
> +++ b/drivers/infiniband/hw/mana/device.c
> @@ -48,6 +48,7 @@ static const struct ib_device_ops mana_ib_dev_ops = {
>  	.query_pkey = mana_ib_query_pkey,
>  	.query_port = mana_ib_query_port,
>  	.reg_user_mr = mana_ib_reg_user_mr,
> +	.reg_user_mr_dmabuf = mana_ib_reg_user_mr_dmabuf,
>  	.req_notify_cq = mana_ib_arm_cq,
> 
>  	INIT_RDMA_OBJ_SIZE(ib_ah, mana_ib_ah, ibah), diff --git
> a/drivers/infiniband/hw/mana/mana_ib.h
> b/drivers/infiniband/hw/mana/mana_ib.h
> index 9eaf983..bd47b7f 100644
> --- a/drivers/infiniband/hw/mana/mana_ib.h
> +++ b/drivers/infiniband/hw/mana/mana_ib.h
> @@ -699,4 +699,8 @@ int mana_ib_post_send(struct ib_qp *ibqp, const struct
> ib_send_wr *wr,
> 
>  int mana_ib_poll_cq(struct ib_cq *ibcq, int num_entries, struct ib_wc *wc);  int
> mana_ib_arm_cq(struct ib_cq *ibcq, enum ib_cq_notify_flags flags);
> +
> +struct ib_mr *mana_ib_reg_user_mr_dmabuf(struct ib_pd *ibpd, u64 start, u64
> length,
> +					 u64 iova, int fd, int mr_access_flags,
> +					 struct uverbs_attr_bundle *attrs);
>  #endif
> diff --git a/drivers/infiniband/hw/mana/mr.c b/drivers/infiniband/hw/mana/mr.c
> index ac3041f..7a71607 100644
> --- a/drivers/infiniband/hw/mana/mr.c
> +++ b/drivers/infiniband/hw/mana/mr.c
> @@ -186,6 +186,83 @@ err_free:
>  	return ERR_PTR(err);
>  }
> 
> +struct ib_mr *mana_ib_reg_user_mr_dmabuf(struct ib_pd *ibpd, u64 start, u64
> length,
> +					 u64 iova, int fd, int access_flags,
> +					 struct uverbs_attr_bundle *attrs) {
> +	struct mana_ib_pd *pd = container_of(ibpd, struct mana_ib_pd, ibpd);
> +	struct gdma_create_mr_params mr_params = {};
> +	struct ib_device *ibdev = ibpd->device;
> +	struct ib_umem_dmabuf *umem_dmabuf;
> +	struct mana_ib_dev *dev;
> +	struct mana_ib_mr *mr;
> +	u64 dma_region_handle;
> +	int err;
> +
> +	dev = container_of(ibdev, struct mana_ib_dev, ib_dev);
> +
> +	ibdev_dbg(ibdev,
> +		  "dmabuf 0x%llx, iova 0x%llx length 0x%llx access_flags 0x%x",
> +		  start, iova, length, access_flags);
> +
> +	access_flags &= ~IB_ACCESS_OPTIONAL;
> +	if (access_flags & ~VALID_MR_FLAGS)
> +		return ERR_PTR(-EOPNOTSUPP);
> +
> +	mr = kzalloc(sizeof(*mr), GFP_KERNEL);
> +	if (!mr)
> +		return ERR_PTR(-ENOMEM);
> +
> +	umem_dmabuf = ib_umem_dmabuf_get_pinned(ibdev, start, length, fd,
> access_flags);
> +	if (IS_ERR(umem_dmabuf)) {
> +		err = PTR_ERR(umem_dmabuf);
> +		ibdev_dbg(ibdev, "Failed to get dmabuf umem, %d\n", err);
> +		goto err_free;
> +	}
> +
> +	mr->umem = &umem_dmabuf->umem;
> +
> +	err = mana_ib_create_dma_region(dev, mr->umem,
> &dma_region_handle, iova);
> +	if (err) {
> +		ibdev_dbg(ibdev, "Failed create dma region for user-mr, %d\n",
> +			  err);
> +		goto err_umem;
> +	}
> +
> +	ibdev_dbg(ibdev,
> +		  "created dma region for user-mr 0x%llx\n",
> +		  dma_region_handle);
> +
> +	mr_params.pd_handle = pd->pd_handle;
> +	mr_params.mr_type = GDMA_MR_TYPE_GVA;
> +	mr_params.gva.dma_region_handle = dma_region_handle;
> +	mr_params.gva.virtual_address = iova;
> +	mr_params.gva.access_flags =
> +		mana_ib_verbs_to_gdma_access_flags(access_flags);
> +
> +	err = mana_ib_gd_create_mr(dev, mr, &mr_params);
> +	if (err)
> +		goto err_dma_region;
> +
> +	/*
> +	 * There is no need to keep track of dma_region_handle after MR is
> +	 * successfully created. The dma_region_handle is tracked in the PF
> +	 * as part of the lifecycle of this MR.
> +	 */
> +
> +	return &mr->ibmr;
> +
> +err_dma_region:
> +	mana_gd_destroy_dma_region(mdev_to_gc(dev), dma_region_handle);
> +
> +err_umem:
> +	ib_umem_release(mr->umem);
> +
> +err_free:
> +	kfree(mr);
> +	return ERR_PTR(err);
> +}
> +
>  struct ib_mr *mana_ib_get_dma_mr(struct ib_pd *ibpd, int access_flags)  {
>  	struct mana_ib_pd *pd = container_of(ibpd, struct mana_ib_pd, ibpd);
> --
> 2.43.0