linux-kernel - Re: [PATCH iwl-next v3 5/6] ice: support egress drop rules on PF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a2828574-8b78-47a8-9ca3-a531f234a4c9@intel.com>
Date: Wed, 12 Feb 2025 13:36:18 -0800
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: Larysa Zaremba <larysa.zaremba@...el.com>,
	<intel-wired-lan@...ts.osuosl.org>
CC: Przemek Kitszel <przemyslaw.kitszel@...el.com>, Andrew Lunn
	<andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, "Eric
 Dumazet" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, Michal Swiatkowski
	<michal.swiatkowski@...ux.intel.com>, Mateusz Pacuszka
	<mateuszx.pacuszka@...el.com>
Subject: Re: [PATCH iwl-next v3 5/6] ice: support egress drop rules on PF



On 2/8/2025 5:22 AM, Larysa Zaremba wrote:

...

> @@ -8393,20 +8395,42 @@ ice_setup_tc_cls_flower(struct ice_netdev_priv *np,
>   }
>   
>   /**
> - * ice_setup_tc_block_cb - callback handler registered for TC block
> + * ice_setup_tc_block_cb_ingress - callback handler for ingress TC block
>    * @type: TC SETUP type
>    * @type_data: TC flower offload data that contains user input
>    * @cb_priv: netdev private data
>    */
>   static int
> -ice_setup_tc_block_cb(enum tc_setup_type type, void *type_data, void *cb_priv)
> +ice_setup_tc_block_cb_ingress(enum tc_setup_type type, void *type_data,
> +			      void *cb_priv)

Could you fix the kdocs on the ones that you modify? Most of them are 
missing the Return:

>   {
>   	struct ice_netdev_priv *np = cb_priv;
>   
>   	switch (type) {
>   	case TC_SETUP_CLSFLOWER:
>   		return ice_setup_tc_cls_flower(np, np->vsi->netdev,
> -					       type_data);
> +					       type_data, true);
> +	default:
> +		return -EOPNOTSUPP;
> +	}
> +}
> +
> +/**
> + * ice_setup_tc_block_cb_egress - callback handler for egress TC block
> + * @type: TC SETUP type
> + * @type_data: TC flower offload data that contains user input
> + * @cb_priv: netdev private data
> + */
> +static int
> +ice_setup_tc_block_cb_egress(enum tc_setup_type type, void *type_data,
> +			     void *cb_priv)

And correct the ones that you're adding.

I believe there's issues of this or the previous in patches 2-5.

Thanks,
Tony

> +{
> +	struct ice_netdev_priv *np = cb_priv;
> +
> +	switch (type) {
> +	case TC_SETUP_CLSFLOWER:
> +		return ice_setup_tc_cls_flower(np, np->vsi->netdev,
> +					       type_data, false);
>   	default:
>   		return -EOPNOTSUPP;
>   	}