linux-kernel - Re: [PATCH] scsi: hpsa: Use min() to simplify code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <561C9EC8-8F5B-4415-B7B7-CBE2AB99A094@linux.dev>
Date: Wed, 12 Feb 2025 23:28:17 +0100
From: Thorsten Blum <thorsten.blum@...ux.dev>
To: Bart Van Assche <bvanassche@....org>
Cc: Don Brace <don.brace@...rochip.com>,
 "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>,
 storagedev@...rochip.com,
 linux-scsi@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: hpsa: Use min() to simplify code

On 12. Feb 2025, at 19:48, Bart Van Assche wrote:
> On 2/12/25 3:55 AM, Thorsten Blum wrote:
>> Use min() to simplify the host_store_hp_ssd_smart_path_status() and
>> host_store_raid_offload_debug() functions.
>> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
>> ---
> 
> From Documentation/process/deprecated.rst:
> 
> <quote>
> strncpy() on NUL-terminated strings
> -----------------------------------
> Use of strncpy() does not guarantee that the destination buffer will
> be NUL terminated. This can lead to various linear read overflows and
> other misbehavior due to the missing termination. It also NUL-pads
> the destination buffer if the source contents are shorter than the
> destination buffer size, which may be a needless performance penalty
> for callers using only NUL-terminated strings.
> 
> When the destination is required to be NUL-terminated, the replacement is
> strscpy(), though care must be given to any cases where the return value
> of strncpy() was used, since strscpy() does not return a pointer to the
> destination, but rather a count of non-NUL bytes copied (or negative
> errno when it truncates). Any cases still needing NUL-padding should
> instead use strscpy_pad().
> 
> If a caller is using non-NUL-terminated strings, strtomem() should be
> used, and the destinations should be marked with the `__nonstring
> <https://gcc.gnu.org/onlinedocs/gcc/Common-Variable-Attributes.html>`_
> attribute to avoid future compiler warnings. For cases still needing
> NUL-padding, strtomem_pad() can be used.
> </quote>
> 
> Instead of only changing the calculation of 'len', please change the
> strncpy() calls into strscpy() calls.

Thank you for the suggestion.

I just sent a new patch [1] essentially replacing this one.

Best,
Thorsten

[1] https://lore.kernel.org/r/20250212222214.86110-2-thorsten.blum@linux.dev/