linux-kernel - Re: [v2,2/2] dt-bindings: memory-controllers: Add MediaTek DRAM controller interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eb63bd2c9e5e31ff189d2c957bfcb4bd222ec778.camel@mediatek.com>
Date: Wed, 12 Feb 2025 03:50:54 +0000
From: Crystal Guo (郭晶) <Crystal.Guo@...iatek.com>
To: "robh@...nel.org" <robh@...nel.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"krzk@...nel.org" <krzk@...nel.org>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>
CC: "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@...iatek.com>
Subject: Re: [v2,2/2] dt-bindings: memory-controllers: Add MediaTek DRAM
 controller interface

On Sun, 2025-02-09 at 11:51 +0100, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 07/02/2025 02:42, Crystal Guo wrote:
> > A MediaTek DRAM controller interface to provide the current DDR
> > data rate.

Hi Krzysztof,

Regarding this commit message, you previously commented as follows: 
"Please wrap commit message according to Linux coding style /     
submission process (neither too early nor over the limit): 
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L5
"

May I ask if this means that the description "A MediaTek DRAM
controller interface to provide the current DDR data rate." needs to be
split into two lines? The total number of characters in this
description is 74.

Thanks
Crystal

> > 
> 
> Duplicated patch.
> 
> You also ignored several comments so that's a NAK.

Apologies for any confusion.

This latest patch and 
https://patchwork.kernel.org/project/linux-mediatek/list/?series=931186
 do indeed overlap. 
Due to the fact that 
https://patchwork.kernel.org/project/linux-mediatek/list/?series=931186
 was pushed based on an incorrect base, please ignore the patch series
931186. 

This latest patch is intended to address the comments provided for the
first version in 
https://patchwork.kernel.org/project/linux-mediatek/list/?series=917099
. It is based on a clean kernel, so could you help review this version?
Thanks.

Best regards
Crystal


> 
> <form letter>
> This is a friendly reminder during the review process.
> 
> It seems my or other reviewer's previous comments were not fully
> addressed. Maybe the feedback got lost between the quotes, maybe you
> just forgot to apply it. Please go back to the previous discussion
> and
> either implement all requested changes or keep discussing them.
> 
> Thank you.
> </form letter>
> 
> Best regards,
> Krzysztof