linux-kernel - Re: [PATCH v5 2/2] arm64: dts: qcom: qcs8300: Add device node for gfx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <075588ff-77e5-4b01-8c67-8fc30e51b8a9@quicinc.com>
Date: Wed, 12 Feb 2025 10:49:58 +0530
From: Pratyush Brahma <quic_pbrahma@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Will Deacon <will@...nel.org>,
        Robin Murphy <robin.murphy@....com>, Joerg Roedel <joro@...tes.org>,
        Rob
 Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor
 Dooley <conor+dt@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad
 Dybcio <konradybcio@...nel.org>
CC: <linux-arm-kernel@...ts.infradead.org>, <iommu@...ts.linux.dev>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCH v5 2/2] arm64: dts: qcom: qcs8300: Add device node for
 gfx_smmu


On 2/12/2025 10:09 AM, Pratyush Brahma wrote:
>
>
> On 2/11/2025 8:45 PM, Krzysztof Kozlowski wrote:
>> On 11/02/2025 05:45, Pratyush Brahma wrote:
>>> Add the device node for gfx smmu that is required for gpu
>>> specific address translations.
>>>
>>> Signed-off-by: Pratyush Brahma<quic_pbrahma@...cinc.com>
>>> ---
>>>   arch/arm64/boot/dts/qcom/qcs8300.dtsi | 39 +++++++++++++++++++++++++++++++++++
>>>   1 file changed, 39 insertions(+)
>> As pointed out by Rob, this wasn't ever tested. One more example of work
>> where you have the binding in the same patch but refuse to use it.
No, I had tested these patches against the dt_bindings_check and didn't 
see these errors.
It seems I need to upgrade my dtschema as Rob pointed out, reorder the 
clocks and resend.
However, I guess I need to update the clock list in the bindings file as 
per the order suggested
by Konrad in version 3.
>> NAK
>>
>> Best regards,
>> Krzysztof
> -- 
> Thanks and Regards
> Pratyush Brahma

-- 
Thanks and Regards
Pratyush Brahma