linux-kernel - Re: [PATCH v6 2/7] arm64: dts: agilex: Fix fixed-clock schema warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bf87b59-fe80-4bb5-a558-bff35d876e67@kernel.org>
Date: Wed, 12 Feb 2025 06:56:09 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Matthew Gerlach <matthew.gerlach@...ux.intel.com>, lpieralisi@...nel.org,
 kw@...ux.com, manivannan.sadhasivam@...aro.org, robh@...nel.org,
 bhelgaas@...gle.com, krzk+dt@...nel.org, conor+dt@...nel.org,
 dinguyen@...nel.org, joyce.ooi@...el.com, linux-pci@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: matthew.gerlach@...era.com, peter.colberg@...era.com
Subject: Re: [PATCH v6 2/7] arm64: dts: agilex: Fix fixed-clock schema
 warnings

On 11/02/2025 16:17, Matthew Gerlach wrote:
> Add required clock-frequency property to fixed-clock nodes
> to fix schema check warnings.
> 
> Signed-off-by: Matthew Gerlach <matthew.gerlach@...ux.intel.com>
> ---
> v6:
>  - New patch to series.
> ---
>  arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
> index 1235ba5a9865..42cb24cfa6da 100644
> --- a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
> @@ -114,21 +114,25 @@ clocks {
>  		cb_intosc_hs_div2_clk: cb-intosc-hs-div2-clk {
>  			#clock-cells = <0>;
>  			compatible = "fixed-clock";
> +			clock-frequency = <0>;

That's not a correct frequency. You silence some error by introducing
incorrect properties. That's wrong.

Don't fix the warnings just to silence them, while keeping actual errors
still in the code.

Best regards,
Krzysztof