linux-kernel - Re: [PATCH 2/2] staging: gpib: fix style at nec7210_t1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a8da3395-e383-48d2-8c1e-fa70874ad551@stanley.mountain>
Date: Wed, 12 Feb 2025 10:07:48 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>
Cc: gregkh@...uxfoundation.org, dpenkler@...il.com,
	~lkcamp/patches@...ts.sr.ht, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] staging: gpib: fix style at nec7210_t1_delay
 definition

On Tue, Feb 11, 2025 at 11:35:37PM -0300, Rodrigo Gobbi wrote:
> due a change of the return type of t1_delay function, checkpatch
> was triggering a style error.
> 
> Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>

This should be folded into the previous patch.  Generally we avoid
introducing checkpatch warnings and then fixing them later.  Sometimes
that ignoring checkpatch and then fixing it later can make the review
easier if a patch is really massive but this change is only medium sized.

regards,
dan carpenter