linux-kernel - Re: [PATCH 1/3] staging: rtl8723bs: format comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1052fff0-b503-4b47-9897-fe7c26c14126@stanley.mountain>
Date: Wed, 12 Feb 2025 10:21:39 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Ian To <onlyian4981@...il.com>
Cc: gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] staging: rtl8723bs: format comments

On Sat, Feb 08, 2025 at 12:15:54AM -0800, Ian To wrote:
> Some comments were not formatted correctly. Reported by checkpatch.
> 
> Signed-off-by: Ian To <onlyian4981@...il.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_security.c | 102 +++++++++---------
>  1 file changed, 51 insertions(+), 51 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/staging/rtl8723bs/core/rtw_security.c
> index 1e9eff01b1aa..3281751436fd 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_security.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_security.c
> @@ -30,10 +30,10 @@ const char *security_type_str(u8 value)
>  /* WEP related ===== */
>  
>  /*
> -	Need to consider the fragment  situation
> -*/
> + *	Need to consider the fragment  situation
> + */
>  void rtw_wep_encrypt(struct adapter *padapter, u8 *pxmitframe)
> -{																	/*  exclude ICV */
> +{								/*  exclude ICV */

What does this comment even mean?

> @@ -374,39 +374,38 @@ static void phase1(u16 *p1k, const u8 *tk, const u8 *ta, u32 iv32)
>  	/* size on the 80-bit block P1K[], using the 128-bit key TK[] */
>  	for (i = 0; i < PHASE1_LOOP_CNT; i++) {
>  		/* Each add operation here is mod 2**16 */
> -		p1k[0] += _S_(p1k[4] ^ TK16((i&1)+0));
> -		p1k[1] += _S_(p1k[0] ^ TK16((i&1)+2));
> -		p1k[2] += _S_(p1k[1] ^ TK16((i&1)+4));
> -		p1k[3] += _S_(p1k[2] ^ TK16((i&1)+6));
> -		p1k[4] += _S_(p1k[3] ^ TK16((i&1)+0));
> +		p1k[0] += _S_(p1k[4] ^ TK16((i & 1) + 0));
> +		p1k[1] += _S_(p1k[0] ^ TK16((i & 1) + 2));
> +		p1k[2] += _S_(p1k[1] ^ TK16((i & 1) + 4));
> +		p1k[3] += _S_(p1k[2] ^ TK16((i & 1) + 6));
> +		p1k[4] += _S_(p1k[3] ^ TK16((i & 1) + 0));

These aren't comments.

regards,
dan carpenter