linux-kernel - Re: [PATCH 1/4] sounds: firewire: isight: changed strcpy to strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87h64zmxrx.wl-tiwai@suse.de>
Date: Wed, 12 Feb 2025 08:23:46 +0100
From: Takashi Iwai <tiwai@...e.de>
To: jack Livingood <jacklivingood@...cast.net>
Cc: sfr@...b.auug.org.au,
	tiwai@...e.de,
	linux-kernel@...r.kernel.org,
	linux-wireless@...r.kernel.org
Subject: Re: [PATCH 1/4] sounds: firewire: isight: changed strcpy to strscpy

On Wed, 12 Feb 2025 02:23:46 +0100,
jack Livingood wrote:
> 
> From: Jack Livingood <jacklivingood@...cast.net>
> 
> fixed a spelling issue in the commit made previous

I already discarded your previous patch, so please give a full
description.


Takashi

> 
> Signed-off-by: Jack Livingood <jacklivingood@...cast.net>
> ---
>  sound/firewire/isight.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/firewire/isight.c b/sound/firewire/isight.c
> index 806f82c9ceee..e9617fc0a532 100644
> --- a/sound/firewire/isight.c
> +++ b/sound/firewire/isight.c
> @@ -637,13 +637,13 @@ static int isight_probe(struct fw_unit *unit,
>  
>  	card->private_free = isight_card_free;
>  
> -	strcpy(card->driver, "iSight");
> -	strcpy(card->shortname, "Apple iSight");
> +	strscpy(card->driver, "iSight");
> +	strscpy(card->shortname, "Apple iSight");
>  	snprintf(card->longname, sizeof(card->longname),
>  		 "Apple iSight (GUID %08x%08x) at %s, S%d",
>  		 fw_dev->config_rom[3], fw_dev->config_rom[4],
>  		 dev_name(&unit->device), 100 << fw_dev->max_speed);
> -	strcpy(card->mixername, "iSight");
> +	strscpy(card->mixername, "iSight");
>  
>  	err = isight_create_pcm(isight);
>  	if (err < 0)
> -- 
> 2.48.1
>