linux-kernel - Re: [PATCH] Staging: nvec: Fix pm_power_off reset condition in tegra_nvec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <429e6aa2-b195-4624-a609-e1445dcbd150@stanley.mountain>
Date: Wed, 12 Feb 2025 10:33:13 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Dima Volkovsk <s0ldw3ll@...il.com>
Cc: marvin24@....de, gregkh@...uxfoundation.org, ac100@...ts.launchpad.net,
	linux-tegra@...r.kernel.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: nvec: Fix pm_power_off reset condition in
 tegra_nvec_remove

On Sun, Feb 09, 2025 at 09:16:48PM +0100, Dima Volkovsk wrote:
> In the current implementation of tegra_nvec_remove, the pm_power_off handler
> is set to NULL without checking if it is actually set to nvec_power_off. This
> change ensures that pm_power_off is only reset if it was previously set to
> nvec_power_off, preventing unintended side effects when removing the device.
> 
> Signed-off-by: Dima Volkovsk <s0ldw3ll@...il.com>

What everyone else said and also you forgot to add a Fixes tag.

regards,
dan carpenter