linux-kernel - Re: [Patch 1/5] ACPI: CPPC: add read perf ctrls api and rename few existing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202502121512.r83JqnGm-lkp@intel.com>
Date: Wed, 12 Feb 2025 16:03:02 +0800
From: kernel test robot <lkp@...el.com>
To: Sumit Gupta <sumitg@...dia.com>, rafael@...nel.org,
	viresh.kumar@...aro.org, lenb@...nel.org, robert.moore@...el.com,
	corbet@....net, linux-pm@...r.kernel.org,
	linux-acpi@...r.kernel.org, linux-doc@...r.kernel.org,
	acpica-devel@...ts.linux.dev, linux-kernel@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, linux-tegra@...r.kernel.org,
	treding@...dia.com, jonathanh@...dia.com, sashal@...dia.com,
	vsethi@...dia.com, ksitaraman@...dia.com, sanjayc@...dia.com,
	bbasu@...dia.com, sumitg@...dia.com
Subject: Re: [Patch 1/5] ACPI: CPPC: add read perf ctrls api and rename few
 existing

Hi Sumit,

kernel test robot noticed the following build errors:

[auto build test ERROR on next-20250210]
[also build test ERROR on linus/master v6.14-rc2]
[cannot apply to rafael-pm/linux-next rafael-pm/bleeding-edge v6.14-rc2 v6.14-rc1 v6.13]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Sumit-Gupta/ACPI-CPPC-add-read-perf-ctrls-api-and-rename-few-existing/20250211-184154
base:   next-20250210
patch link:    https://lore.kernel.org/r/20250211103737.447704-2-sumitg%40nvidia.com
patch subject: [Patch 1/5] ACPI: CPPC: add read perf ctrls api and rename few existing
config: x86_64-buildonly-randconfig-005-20250212 (https://download.01.org/0day-ci/archive/20250212/202502121512.r83JqnGm-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250212/202502121512.r83JqnGm-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502121512.r83JqnGm-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/cpufreq/amd-pstate.c: In function 'shmem_cppc_enable':
>> drivers/cpufreq/amd-pstate.c:395:31: error: implicit declaration of function 'cppc_set_perf'; did you mean 'cppc_set_epp_perf'? [-Werror=implicit-function-declaration]
     395 |                         ret = cppc_set_perf(cpu, &perf_ctrls);
         |                               ^~~~~~~~~~~~~
         |                               cppc_set_epp_perf
   cc1: some warnings being treated as errors


vim +395 drivers/cpufreq/amd-pstate.c

ec437d71db77a1 Huang Rui         2021-12-24  377  
7fb463aac84577 Dhananjay Ugwekar 2024-10-23  378  static int shmem_cppc_enable(bool enable)
e059c184da47e9 Huang Rui         2021-12-24  379  {
e059c184da47e9 Huang Rui         2021-12-24  380  	int cpu, ret = 0;
ffa5096a7c3386 Perry Yuan        2023-01-31  381  	struct cppc_perf_ctrls perf_ctrls;
e059c184da47e9 Huang Rui         2021-12-24  382  
217e67784eab30 Wyes Karny        2023-05-30  383  	if (enable == cppc_enabled)
217e67784eab30 Wyes Karny        2023-05-30  384  		return 0;
217e67784eab30 Wyes Karny        2023-05-30  385  
e059c184da47e9 Huang Rui         2021-12-24  386  	for_each_present_cpu(cpu) {
e059c184da47e9 Huang Rui         2021-12-24  387  		ret = cppc_set_enable(cpu, enable);
e059c184da47e9 Huang Rui         2021-12-24  388  		if (ret)
e059c184da47e9 Huang Rui         2021-12-24  389  			return ret;
ffa5096a7c3386 Perry Yuan        2023-01-31  390  
ffa5096a7c3386 Perry Yuan        2023-01-31  391  		/* Enable autonomous mode for EPP */
ffa5096a7c3386 Perry Yuan        2023-01-31  392  		if (cppc_state == AMD_PSTATE_ACTIVE) {
ffa5096a7c3386 Perry Yuan        2023-01-31  393  			/* Set desired perf as zero to allow EPP firmware control */
ffa5096a7c3386 Perry Yuan        2023-01-31  394  			perf_ctrls.desired_perf = 0;
ffa5096a7c3386 Perry Yuan        2023-01-31 @395  			ret = cppc_set_perf(cpu, &perf_ctrls);
ffa5096a7c3386 Perry Yuan        2023-01-31  396  			if (ret)
ffa5096a7c3386 Perry Yuan        2023-01-31  397  				return ret;
ffa5096a7c3386 Perry Yuan        2023-01-31  398  		}
e059c184da47e9 Huang Rui         2021-12-24  399  	}
e059c184da47e9 Huang Rui         2021-12-24  400  
217e67784eab30 Wyes Karny        2023-05-30  401  	cppc_enabled = enable;
e059c184da47e9 Huang Rui         2021-12-24  402  	return ret;
e059c184da47e9 Huang Rui         2021-12-24  403  }
e059c184da47e9 Huang Rui         2021-12-24  404  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki