linux-kernel - Re: [Patch 5/5] cpufreq: CPPC: Add cppc_cpufreq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202502121734.xMnvqs6o-lkp@intel.com>
Date: Wed, 12 Feb 2025 17:27:58 +0800
From: kernel test robot <lkp@...el.com>
To: Sumit Gupta <sumitg@...dia.com>, rafael@...nel.org,
	viresh.kumar@...aro.org, lenb@...nel.org, robert.moore@...el.com,
	corbet@....net, linux-pm@...r.kernel.org,
	linux-acpi@...r.kernel.org, linux-doc@...r.kernel.org,
	acpica-devel@...ts.linux.dev, linux-kernel@...r.kernel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	linux-tegra@...r.kernel.org, treding@...dia.com,
	jonathanh@...dia.com, sashal@...dia.com, vsethi@...dia.com,
	ksitaraman@...dia.com, sanjayc@...dia.com, bbasu@...dia.com,
	sumitg@...dia.com
Subject: Re: [Patch 5/5] cpufreq: CPPC: Add cppc_cpufreq_epp instance for
 Autonomous mode

Hi Sumit,

kernel test robot noticed the following build warnings:

[auto build test WARNING on next-20250210]
[cannot apply to rafael-pm/linux-next rafael-pm/bleeding-edge v6.14-rc2 v6.14-rc1 v6.13 linus/master v6.14-rc2]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Sumit-Gupta/ACPI-CPPC-add-read-perf-ctrls-api-and-rename-few-existing/20250211-184154
base:   next-20250210
patch link:    https://lore.kernel.org/r/20250211103737.447704-6-sumitg%40nvidia.com
patch subject: [Patch 5/5] cpufreq: CPPC: Add cppc_cpufreq_epp instance for Autonomous mode
config: riscv-randconfig-001-20250212 (https://download.01.org/0day-ci/archive/20250212/202502121734.xMnvqs6o-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project 6807164500e9920638e2ab0cdb4bf8321d24f8eb)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250212/202502121734.xMnvqs6o-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502121734.xMnvqs6o-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/cpufreq/cppc_cpufreq.c:780:68: warning: more '%' conversions than data arguments [-Wformat-insufficient-args]
     780 |         pr_debug("cpu%d, curr epp:%u, new epp:%u, curr mode:%u, new mode:%u\n",
         |                                                                          ~^
   include/linux/printk.h:631:30: note: expanded from macro 'pr_debug'
     631 |         no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
         |                                     ^~~
   drivers/cpufreq/cppc_cpufreq.c:11:37: note: expanded from macro 'pr_fmt'
      11 | #define pr_fmt(fmt)     "CPPC Cpufreq:" fmt
         |                                         ^~~
   include/linux/printk.h:135:11: note: expanded from macro 'no_printk'
     135 |                 _printk(fmt, ##__VA_ARGS__);            \
         |                         ^~~
>> drivers/cpufreq/cppc_cpufreq.c:799:23: warning: unused variable 'cpu_data' [-Wunused-variable]
     799 |         struct cppc_cpudata *cpu_data = policy->driver_data;
         |                              ^~~~~~~~
   drivers/cpufreq/cppc_cpufreq.c:1018:23: warning: unused variable 'cpu_data' [-Wunused-variable]
    1018 |         struct cppc_cpudata *cpu_data;
         |                              ^~~~~~~~
>> drivers/cpufreq/cppc_cpufreq.c:1019:11: warning: unused variable 'pref' [-Wunused-variable]
    1019 |         int cpu, pref, ret = 0;
         |                  ^~~~
   4 warnings generated.


vim +780 drivers/cpufreq/cppc_cpufreq.c

   773	
   774	static int cppc_cpufreq_epp_update_auto_mode(struct cpufreq_policy *policy, int auto_sel, u32 epp)
   775	{
   776		struct cppc_cpudata *cpu_data = policy->driver_data;
   777		int ret, curr_epp;
   778	
   779		curr_epp = cpu_data->perf_ctrls.energy_perf;
 > 780		pr_debug("cpu%d, curr epp:%u, new epp:%u, curr mode:%u, new mode:%u\n",
   781			 curr_epp, epp, cpu_data->perf_caps.auto_sel, auto_sel);
   782	
   783		/* set Performance preference as default */
   784		cpu_data->perf_ctrls.energy_perf = epp;
   785		ret = cppc_set_epp_perf(policy->cpu, &cpu_data->perf_ctrls, auto_sel);
   786		if (ret < 0) {
   787			pr_err("failed to set energy perf value (%d)\n", ret);
   788			cpu_data->perf_ctrls.energy_perf = curr_epp;
   789			return ret;
   790		}
   791		cpu_data->perf_caps.auto_sel = auto_sel;
   792	
   793		return ret;
   794	}
   795	
   796	static int cppc_cpufreq_epp_update_perf(struct cpufreq_policy *policy, int auto_sel, u32 epp,
   797						u32 highest_perf, u32 lowest_perf)
   798	{
 > 799		struct cppc_cpudata *cpu_data = policy->driver_data;
   800		int ret;
   801	
   802		ret = cppc_cpufreq_epp_update_perf_ctrls(policy, highest_perf, lowest_perf);
   803		if (ret)
   804			return ret;
   805	
   806		ret = cppc_cpufreq_epp_update_auto_mode(policy, auto_sel, epp);
   807		if (ret)
   808			return ret;
   809	
   810		return ret;
   811	}
   812	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki