linux-kernel - Re: [PATCH v2 00/35] drm/bridge: Various quality of life improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b5og5jvjq4jnq5rogyro5rtahayvsbroq4z3yrplioyb4itbak@3cepdouqxyny>
Date: Wed, 12 Feb 2025 02:51:04 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Maxime Ripard <mripard@...nel.org>
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, 
	Simona Vetter <simona@...ll.ch>, Andrzej Hajda <andrzej.hajda@...el.com>, 
	Neil Armstrong <neil.armstrong@...aro.org>, Robert Foss <rfoss@...nel.org>, 
	Laurent Pinchart <Laurent.pinchart@...asonboard.com>, Jonas Karlman <jonas@...boo.se>, 
	Jernej Skrabec <jernej.skrabec@...il.com>, Douglas Anderson <dianders@...omium.org>, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, 
	Simona Vetter <simona.vetter@...ll.ch>
Subject: Re: [PATCH v2 00/35] drm/bridge: Various quality of life improvements

On Tue, Feb 11, 2025 at 02:17:30PM +0100, Maxime Ripard wrote:
> On Sun, Feb 09, 2025 at 05:27:01AM +0200, Dmitry Baryshkov wrote:
> > On Tue, Feb 04, 2025 at 03:57:28PM +0100, Maxime Ripard wrote:
> > > Hi,
> > > 
> > > Here's a series of changes after to the KMS helpers and bridge API
> > > following a bunch of reviews I did.
> > > 
> > > It's mostly centered across providing an easier time to deal with bridge
> > > states, and a somewhat consistent with the other entities API.
> > > 
> > > It's build tested only, with arm64 allmodconfig.
> > > 
> > > Maxime
> > > 
> > > Signed-off-by: Maxime Ripard <mripard@...nel.org>
> > > ---
> > > Changes in v2:
> > > - Pass the full atomic state to bridge atomic hooks
> > > - Make attach take the encoder as a parameter
> > > - Mark bridge->encoder as deprecated
> > > - Rework the logic to detect if a bridge uses a state or not at
> > >   atomic_check time
> > > - Add lockdep assertion to drm_bridge_get_current_state()
> > > - Link to v1: https://lore.kernel.org/r/20250115-bridge-connector-v1-0-9a2fecd886a6@kernel.org
> > > 
> > > ---
> > > Maxime Ripard (35):
> > >       drm/atomic: Document history of drm_atomic_state
> > >       drm/bridge: Pass full state to atomic_pre_enable
> > >       drm/bridge: Pass full state to atomic_enable
> > >       drm/bridge: Pass full state to atomic_disable
> > >       drm/bridge: Pass full state to atomic_post_disable
> > >       drm/atomic-helper: Fix commit_tail state variable name
> > >       drm/atomic-helper: Change parameter name of drm_atomic_helper_wait_for_dependencies()
> > >       drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_tail()
> > >       drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_tail_rpm()
> > >       drm/atomic-helper: Change parameter name of drm_atomic_helper_modeset_disables()
> > >       drm/atomic-helper: Change parameter name of disable_outputs()
> > >       drm/bridge: Change parameter name of drm_atomic_bridge_chain_disable()
> > >       drm/bridge: Change parameter name of drm_atomic_bridge_chain_post_disable()
> > >       drm/atomic-helper: Change parameter name of drm_atomic_helper_update_legacy_modeset_state()
> > >       drm/atomic-helper: Change parameter name of crtc_set_mode()
> > >       drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_planes()
> > >       drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_modeset_enables()
> > >       drm/bridge: Change parameter name of drm_atomic_bridge_chain_pre_enable()
> > >       drm/bridge: Change parameter name of drm_atomic_bridge_chain_enable()
> > >       drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_writebacks()
> > >       drm/atomic-helper: Change parameter name of drm_atomic_helper_fake_vblank()
> > >       drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_hw_done()
> > >       drm/atomic-helper: Change parameter name of drm_atomic_helper_wait_for_vblanks()
> > >       drm/atomic-helper: Change parameter name of drm_atomic_helper_cleanup_planes()
> > >       drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_cleanup_done()
> > >       drm/atomic-helper: Change parameter name of drm_atomic_helper_wait_for_flip_done()
> > 
> > I agree that use of the old_state can be confusing (and it has been
> > confusing to me for some time). The main question is, do we loose useful
> > memo 'this is the state after swap'. Most likely it is useless now, just
> > wanted to give it a second thought.
> 
> The drm_atomic_state doesn't change after a swap, only the
> plane/crtc/connector/private_obj (and their state) state pointer do. And
> if you meant that old_state mentions that the states have been swapped,
> it's still a terrible name and we should change it still :)

Ack, sounds good.

-- 
With best wishes
Dmitry