linux-kernel - Re: [PATCH v2 17/18] firmware: arm_ffa: Add support for handling framework notifications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z6x-kXUb9bvFOUco@bogus>
Date: Wed, 12 Feb 2025 10:57:21 +0000
From: Sudeep Holla <sudeep.holla@....com>
To: Viresh Kumar <viresh.kumar@...aro.org>
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 17/18] firmware: arm_ffa: Add support for handling
 framework notifications

On Mon, Feb 10, 2025 at 03:47:43PM +0530, Viresh Kumar wrote:
> On 31-01-25, 11:24, Sudeep Holla wrote:
> > +static void handle_fwk_notif_callbacks(u32 bitmap)
> > +{
> > +	void *buf;
> > +	uuid_t uuid;
> > +	int notify_id = 0, target;
> > +	struct ffa_indirect_msg_hdr *msg;
> > +	struct notifier_cb_info *cb_info = NULL;
> > +
> > +	/* Only one framework notification defined and supported for now */
> > +	if (!(bitmap & FRAMEWORK_NOTIFY_RX_BUFFER_FULL))
> > +		return;
> > +
> > +	mutex_lock(&drv_info->rx_lock);
> > +
> > +	msg = drv_info->rx_buffer;
> > +	buf = kmalloc(msg->size, GFP_KERNEL);
> > +	if (!buf) {
> > +		mutex_unlock(&drv_info->rx_lock);
> > +		return;
> > +	}
> > +	memcpy(buf, (void *)msg + msg->offset, msg->size);
> 
> Can use kmemdup() here instead.
> 

Thanks for the suggestion. I have fixed locally. I will not respin the
series if there are no other major changes needed, will apply with this
suggestion included directly.

-- 
Regards,
Sudeep