linux-kernel - Re: [PATCH v5 02/12] driver core: Split devres APIs to device/devres.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z6x_Zrt6byWCo1I9@smile.fi.intel.com>
Date: Wed, 12 Feb 2025 13:00:54 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Arnd Bergmann <arnd@...db.de>
Cc: Raag Jadav <raag.jadav@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Rafael J . Wysocki" <rafael@...nel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Jonathan Cameron <jic23@...nel.org>,
	Przemek Kitszel <przemyslaw.kitszel@...el.com>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
	linux-iio@...r.kernel.org
Subject: Re: [PATCH v5 02/12] driver core: Split devres APIs to
 device/devres.h

On Wed, Feb 12, 2025 at 07:41:47AM +0100, Arnd Bergmann wrote:
> On Wed, Feb 12, 2025, at 07:25, Raag Jadav wrote:
> > From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> >
> > device.h is a huge header which is hard to follow and easy to miss
> > something. Improve that by splitting devres APIs to device/devres.h.
> >
> > In particular this helps to speedup the build of the code that includes
> > device.h solely for a devres APIs.
> >
> > While at it, cast the error pointers to __iomem using IOMEM_ERR_PTR()
> > and fix sparse warnings.

...

> Acked-by: Arnd Bergmann <arnd@...db.de>

Thank you!

> Splitting this out makes a lot of sense conceptually, though
> I don't think it will actually help with build speed: In order
> to see real benefits, we'd need to remove the linux/device.h
> inclusion from other headers that are frequently included,
> but those don't really rely on the devres interfaces.

Yeah, that's just yet another baby step to the right direction, but it won't
change picture if being alone. I already did a number of patches to split
kernel.h and removing it from other headers, but a lot of work is still ahead
and it's not my hight priority task...

-- 
With Best Regards,
Andy Shevchenko