linux-kernel - Re: [PATCH 5/9] vhost-scsi: log control queue write descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a6ea0706-e8b0-4416-86b3-c6eeeda49760@oracle.com>
Date: Tue, 11 Feb 2025 19:08:39 -0600
From: Mike Christie <michael.christie@...cle.com>
To: Dongli Zhang <dongli.zhang@...cle.com>, virtualization@...ts.linux.dev,
        netdev@...r.kernel.org, kvm@...r.kernel.org
Cc: mst@...hat.com, jasowang@...hat.com, eperezma@...hat.com,
        pbonzini@...hat.com, stefanha@...hat.com, joao.m.martins@...cle.com,
        joe.jin@...cle.com, si-wei.liu@...cle.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/9] vhost-scsi: log control queue write descriptors

On 2/7/25 12:41 PM, Dongli Zhang wrote:
> @@ -378,6 +384,11 @@ static void vhost_scsi_release_tmf_res(struct vhost_scsi_tmf *tmf)
>  {
>  	struct vhost_scsi_inflight *inflight = tmf->inflight;
>  
> +	if (tmf->tmf_log_num) {
> +		kfree(tmf->tmf_log);
> +		tmf->tmf_log_num = 0;

Just a small nit. We can drop this line above. We free
the struct on the next line so it's not useful.

> +	}
> +
>  	kfree(tmf);