linux-kernel - Re: [PATCH v2 2/3] usb: dwc3: gadget: Add support for snps,reserved-endpoints property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250212011356.zfunxnam7e6dtb76@synopsys.com>
Date: Wed, 12 Feb 2025 01:13:59 +0000
From: Thinh Nguyen <Thinh.Nguyen@...opsys.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Felipe Balbi
	<balbi@...nel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Rob Herring
	<robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
	<conor+dt@...nel.org>, Ferry Toth <fntoth@...il.com>
Subject: Re: [PATCH v2 2/3] usb: dwc3: gadget: Add support for
 snps,reserved-endpoints property

On Wed, Feb 12, 2025, Thinh Nguyen wrote:
> On Mon, Feb 03, 2025, Andy Shevchenko wrote:
> >  
> > +static int dwc3_gadget_parse_reserved_endpoints(struct dwc3 *dwc, const char *propname,
> > +						u8 *eps, u8 num)
> > +{
> > +	u8 count;
> > +	int ret;
> > +
> > +	if (!device_property_present(dwc->dev, propname))
> > +		return 0;
> > +
> > +	ret = device_property_count_u8(dwc->dev, propname);
> > +	if (ret < 0)
> > +		return ret;
> > +	count = ret;
> > +
> > +	ret = device_property_read_u8_array(dwc->dev, propname, eps, min(num, count));
> 
> Why do min(num, count)? Can we just put the size of the eps array as
> specified by the function doc.
> 

Actually ignore this. What you have here is fine.

Thanks,
Thinh