linux-kernel - Re: [PATCH v1 1/1] virtio_console: Get rid of unneeded temporary variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <60d61b5bf637370f0eeda0e331b9da2c29fbf2b4.camel@kernel.org>
Date: Wed, 12 Feb 2025 13:19:23 +0100
From: Amit Shah <amit@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, 
	virtualization@...ts.linux.dev, linux-kernel@...r.kernel.org
Cc: Arnd Bergmann <arnd@...db.de>, Greg Kroah-Hartman
	 <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v1 1/1] virtio_console: Get rid of unneeded temporary
 variable

On Mon, 2025-02-10 at 11:59 +0200, Andy Shevchenko wrote:
> When compiling a kernel with GCC using `make W=1` with
> CONFIG_WERROR=y
> (which is default nowadays), the build fails:
> 
> drivers/char/virtio_console.c:1427:9: note: ‘snprintf’ output between
> 9 and 27 bytes into a destination of size 16
> 
> Indeed, GCC can't see the limits of the variables that are in use.
> Fix this by using dev_name() of the newly created device that is
> luckily the same as the string used for the DebugFS node name.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/char/virtio_console.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

Reviewed-by: Amit Shah <amit@...nel.org>