linux-kernel - Re: [PATCH] pinctrl: Fix potential NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <93a7e08f-8a3b-42cc-8d36-f570f02087c8@web.de>
Date: Wed, 12 Feb 2025 13:45:18 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Chenyuan Yang <chenyuan0y@...il.com>, linux-gpio@...r.kernel.org,
 linux-renesas-soc@...r.kernel.org, netdev@...r.kernel.org,
 Angelo Gioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Geert Uytterhoeven <geert+renesas@...der.be>,
 Linus Walleij <linus.walleij@...aro.org>,
 Matthias Brugger <matthias.bgg@...il.com>,
 Richard Cochran <richardcochran@...il.com>
Cc: LKML <linux-kernel@...r.kernel.org>, Zijie Zhao <zzjas98@...il.com>
Subject: Re: [PATCH] pinctrl: Fix potential NULL pointer dereference

> The `chip.label` could be NULL. Add missing check in the
> rza2_gpio_register().

Another wording suggestion:
The data structure member “chip.label” could become NULL
after a failed devm_kasprintf() call in the implementation
of the function “rza2_gpio_register”.
Thus add a check for such a return value.

How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.14-rc2#n145

Can a summary phrase like “Prevent null pointer dereference in rza2_gpio_register()”
be nicer?

> This is similar to commit 3027e7b15b02
> ("ice: Fix some null pointer dereference issues in ice_ptp.c").
> Besides, mediatek_gpio_bank_probe() in drivers/gpio/gpio-mt7621.c also
> has a very similar check.

I find such auxiliary information not so relevant here.

Regards,
Markus