linux-kernel - Re: [PATCH v7 2/7] kexec: define functions to map and unmap segments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b7dd78f21a9fa9dc3b6f90eae2668cfe5c7670c7.camel@linux.ibm.com>
Date: Wed, 12 Feb 2025 08:03:17 -0500
From: Mimi Zohar <zohar@...ux.ibm.com>
To: steven chen <chenste@...ux.microsoft.com>, stefanb@...ux.ibm.com,
        roberto.sassu@...weicloud.com, roberto.sassu@...wei.com,
        eric.snowberg@...cle.com, ebiederm@...ssion.com, paul@...l-moore.com,
        code@...icks.com, bauermann@...abnow.com,
        linux-integrity@...r.kernel.org, kexec@...ts.infradead.org,
        linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: madvenka@...ux.microsoft.com, nramas@...ux.microsoft.com,
        James.Bottomley@...senPartnership.com
Subject: Re: [PATCH v7 2/7] kexec: define functions to map and unmap segments

On Mon, 2025-02-10 at 09:06 -0800, steven chen wrote:
> On 2/7/2025 11:15 AM, Mimi Zohar wrote:
> > Hi Steven,
> > 
> > On Mon, 2025-02-03 at 15:20 -0800, steven chen wrote:
> > > Currently, the mechanism to map and unmap segments to the kimage
> > > structure is not available to the subsystems outside of kexec.  This
> > > functionality is needed when IMA is allocating the memory segments
> > > during kexec 'load' operation.  Implement functions to map and unmap
> > > segments to kimage.
> > > 
> > > Implement kimage_map_segment() to enable mapping of IMA buffer source
> > > pages to the kimage structure post kexec 'load'.  This function,
> > > accepting a kimage pointer, an address, and a size, will gather the
> > > source pages within the specified address range, create an array of page
> > > pointers, and map these to a contiguous virtual address range.  The
> > > function returns the start of this range if successful, or NULL if
> > > unsuccessful.
> > > 
> > > Implement kimage_unmap_segment() for unmapping segments
> > > using vunmap().
> > > 
> > > From: Tushar Sugandhi <tusharsu@...ux.microsoft.com>
> > > Author: Tushar Sugandhi <tusharsu@...ux.microsoft.com>
> > > Reviewed-by: Stefan Berger <stefanb@...ux.ibm.com>
> > > Reviewed-by: Mimi Zohar <zohar@...ux.ibm.com>
> > I don't recall previously adding my "Reviewed-by" tag.
> > 
> > Eric, I'd appreciate your reviewing this and the subsequent patch "[PATCH v7 3/7]
> > ima: kexec: skip IMA segment validation after kexec soft reboot" in particular.
> Hi Eric, Could you help to review this patch as Mimi mentioned? Thanks!
> > 
> > > Signed-off-by: Tushar Sugandhi <tusharsu@...ux.microsoft.com>

Steven, since these patches impact kdump, before re-posting the patch set, please
include the following tags before your Signed-off-by tag on the kexec patches.

Cc: Eric Biederman <ebiederm@...ssion.com>
Cc: Baoquan He <bhe@...hat.com>                                             
Cc: Vivek Goyal <vgoyal@...hat.com>                                         
Cc: Dave Young <dyoung@...hat.com>   

> > > Signed-off-by: steven chen <chenste@...ux.microsoft.com>

thanks,

Mimi