linux-kernel - Re: [PATCH v2 07/17] hwmon: Fix Intel Family-model checks to include extended Families

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0a5f0c0e1a8dc7b76edabfba4bc8bb61a9db3cfd.camel@intel.com>
Date: Wed, 12 Feb 2025 13:10:57 +0000
From: "Zhang, Rui" <rui.zhang@...el.com>
To: "Mehta, Sohil" <sohil.mehta@...el.com>, "Luck, Tony"
	<tony.luck@...el.com>, "Hansen, Dave" <dave.hansen@...el.com>,
	"x86@...nel.org" <x86@...nel.org>, "dave.hansen@...ux.intel.com"
	<dave.hansen@...ux.intel.com>
CC: "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"viresh.kumar@...aro.org" <viresh.kumar@...aro.org>,
	"andrew.cooper3@...rix.com" <andrew.cooper3@...rix.com>,
	"alexander.shishkin@...ux.intel.com" <alexander.shishkin@...ux.intel.com>,
	"luto@...nel.org" <luto@...nel.org>, "david.laight.linux@...il.com"
	<david.laight.linux@...il.com>, "linux-hwmon@...r.kernel.org"
	<linux-hwmon@...r.kernel.org>, "linux-perf-users@...r.kernel.org"
	<linux-perf-users@...r.kernel.org>, "Hunter, Adrian"
	<adrian.hunter@...el.com>, "jdelvare@...e.com" <jdelvare@...e.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"mingo@...hat.com" <mingo@...hat.com>, "irogers@...gle.com"
	<irogers@...gle.com>, "tglx@...utronix.de" <tglx@...utronix.de>,
	"fenghua.yu@...el.com" <fenghua.yu@...el.com>, "lenb@...nel.org"
	<lenb@...nel.org>, "kan.liang@...ux.intel.com" <kan.liang@...ux.intel.com>,
	"linux@...ck-us.net" <linux@...ck-us.net>, "hpa@...or.com" <hpa@...or.com>,
	"peterz@...radead.org" <peterz@...radead.org>, "mark.rutland@....com"
	<mark.rutland@....com>, "bp@...en8.de" <bp@...en8.de>, "acme@...nel.org"
	<acme@...nel.org>, "rafael@...nel.org" <rafael@...nel.org>,
	"jolsa@...nel.org" <jolsa@...nel.org>, "linux-acpi@...r.kernel.org"
	<linux-acpi@...r.kernel.org>, "namhyung@...nel.org" <namhyung@...nel.org>
Subject: Re: [PATCH v2 07/17] hwmon: Fix Intel Family-model checks to include
 extended Families

On Tue, 2025-02-11 at 12:58 -0800, Dave Hansen wrote:
> On 2/11/25 11:43, Sohil Mehta wrote:
> > +       /*
> > +        * Return without adjustment if the Family isn't 6.
> > +        * The rest of the function assumes Family 6.
> > +        */
> > +       if (c->x86 != 6)
> > +               return tjmax;
> 
> Shouldn't we be converting this over to the vfm matches?
> 
> This is kinda icky:
> 
> > +       return family > 15 ||
> > +              (family == 6 &&
> > +               model > 0xe &&
> > +               model != 0x1c &&
> > +               model != 0x26 &&
> > +               model != 0x27 &&
> > +               model != 0x35 &&
> > +               model != 0x36);
> >  }
> 
> I'm not sure how this escaped so far. Probably because it's not in
> arch/x86.
> 
This code was introduced 10+ years ago, and it only brings a warning
message when reading MSR_IA32_TEMPERATURE_TARGET fails.
So probably no one has ever checked this.

thanks,
rui