linux-kernel - Re: [PATCH net-next v4 3/3] net: phy: dp83822: Add support for changing the transmit amplitude voltage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0ab7e964-3e0a-487c-885a-6d20f4482762@lunn.ch>
Date: Wed, 12 Feb 2025 14:18:19 +0100
From: Andrew Lunn <andrew@...n.ch>
To: dimitri.fedrau@...bherr.com
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Andrew Davis <afd@...com>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Dimitri Fedrau <dima.fedrau@...il.com>
Subject: Re: [PATCH net-next v4 3/3] net: phy: dp83822: Add support for
 changing the transmit amplitude voltage

> +	if (dp83822->tx_amplitude_100base_tx_index >= 0)
> +		phy_modify_mmd(phydev, MDIO_MMD_VEND2, MII_DP83822_LDCTRL,
> +			       DP83822_100BASE_TX_LINE_DRIVER_SWING,
> +			       FIELD_PREP(DP83822_100BASE_TX_LINE_DRIVER_SWING,
> +					  dp83822->tx_amplitude_100base_tx_index));

So the driver leaves the value unchanged by default. Please make the
code and the binding match.

	Andrew