linux-kernel - Re: [PATCH] io_uring: pass struct io_tw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <80ba6f5e-33dc-4f06-9277-96ae99d89239@gmail.com>
Date: Wed, 12 Feb 2025 13:31:29 +0000
From: Pavel Begunkov <asml.silence@...il.com>
To: Caleb Sander Mateos <csander@...estorage.com>,
 Jens Axboe <axboe@...nel.dk>
Cc: io-uring@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] io_uring: pass struct io_tw_state by value

On 2/11/25 21:45, Caleb Sander Mateos wrote:
...
> --- a/io_uring/waitid.c
> +++ b/io_uring/waitid.c
> @@ -14,11 +14,11 @@
>   #include "io_uring.h"
>   #include "cancel.h"
>   #include "waitid.h"
>   #include "../kernel/exit.h"
>   
> -static void io_waitid_cb(struct io_kiocb *req, struct io_tw_state *ts);
> +static void io_waitid_cb(struct io_kiocb *req, struct io_tw_state ts);
>   
>   #define IO_WAITID_CANCEL_FLAG	BIT(31)
>   #define IO_WAITID_REF_MASK	GENMASK(30, 0)
>   
>   struct io_waitid {
> @@ -129,11 +129,11 @@ static void io_waitid_complete(struct io_kiocb *req, int ret)
>   
>   	ret = io_waitid_finish(req, ret);
>   	if (ret < 0)
>   		req_set_fail(req);
>   	io_req_set_res(req, ret, 0);
> -	io_req_task_complete(req, &ts);

This thing will need to be fixed first


> +	io_req_task_complete(req, ts);
>   }

-- 
Pavel Begunkov