linux-kernel - RE: [PATCH] EDAC/igen6: Fix the flood of invalid error reports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CY8PR11MB7134D73FF4D4B8733AA4B56289FC2@CY8PR11MB7134.namprd11.prod.outlook.com>
Date: Wed, 12 Feb 2025 13:44:27 +0000
From: "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
To: Markus Elfring <Markus.Elfring@....de>, "linux-edac@...r.kernel.org"
	<linux-edac@...r.kernel.org>, "Luck, Tony" <tony.luck@...el.com>
CC: LKML <linux-kernel@...r.kernel.org>, Borislav Petkov <bp@...en8.de>, James
 Morse <james.morse@....com>, John Audia <therealgraysky@...ton.me>, Mauro
 Carvalho Chehab <mchehab@...nel.org>, "ramses@...l-founded.dev"
	<ramses@...l-founded.dev>, Robert Richter <rric@...nel.org>
Subject: RE: [PATCH] EDAC/igen6: Fix the flood of invalid error reports

> From: Markus Elfring <Markus.Elfring@....de>
> [...]
> > @@ -785,13 +785,22 @@ static u64 ecclog_read_and_clear(struct
> > igen6_imc *imc)  {
> …
> > +	if (ecclog == ~0)
> …
> > +	if (!(ecclog & (ECC_ERROR_LOG_CE | ECC_ERROR_LOG_UE)))
> …
> 
> May these condition checks be combined without repeating the statement
> “return 0;”?

Thanks for the suggestion. Yes.
However, I think that using separate "return 0" statements makes the
code more readable.

-Qiuxu