linux-kernel - Re: [PATCH] drivers: core: fix device leak in __fw_devlink_relax

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250213150250.4be60b24@booty>
Date: Thu, 13 Feb 2025 15:02:50 +0100
From: Luca Ceresoli <luca.ceresoli@...tlin.com>
To: Saravana Kannan <saravanak@...gle.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "Rafael J. Wysocki"
 <rafael@...nel.org>, Danilo Krummrich <dakr@...nel.org>, Thomas Petazzoni
 <thomas.petazzoni@...tlin.com>, Hervé Codina
 <herve.codina@...tlin.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: core: fix device leak in
 __fw_devlink_relax_cycles()

Hi Saravana,

On Thu, 13 Feb 2025 00:11:31 -0800
Saravana Kannan <saravanak@...gle.com> wrote:

> On Wed, Feb 12, 2025 at 2:31 AM Luca Ceresoli <luca.ceresoli@...tlin.com> wrote:
> >
> > Commit bac3b10b78e5 ("driver core: fw_devlink: Stop trying to optimize
> > cycle detection logic") introduced a new struct device *con_dev and a
> > get_dev_from_fwnode() call to get it, but without adding a corresponding
> > put_device().  
> 
> Thanks for debugging this and fixing it! Glad to see more people
> fixing fw_devlink code :)
> 
> > Link: https://lore.kernel.org/all/20241204124826.2e055091@booty/  
> Use the Closes: tag for this link. That tag is used to point to the
> bug report that this patch is fixing.

Good point! Sending v2 with Closes: tag and Cc: stable.

Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com