linux-kernel - Re: [PATCH v2] ww_mutex: convert self-test to KUnit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ-ks9mzYWSvVD=PCvCBohXg77BdFODq4ePMNstkL+70tkU5RA@mail.gmail.com>
Date: Thu, 13 Feb 2025 10:42:24 -0500
From: Tamir Duberstein <tamird@...il.com>
To: Peter Zijlstra <peterz@...radead.org>
Cc: David Gow <davidgow@...gle.com>, Ingo Molnar <mingo@...hat.com>, Will Deacon <will@...nel.org>, 
	Boqun Feng <boqun.feng@...il.com>, Waiman Long <longman@...hat.com>, 
	Andrew Morton <akpm@...ux-foundation.org>, Shuah Khan <shuah@...nel.org>, 
	Nathan Chancellor <nathan@...nel.org>, Nick Desaulniers <ndesaulniers@...gle.com>, 
	Bill Wendling <morbo@...gle.com>, Justin Stitt <justinstitt@...gle.com>, 
	Dan Carpenter <dan.carpenter@...aro.org>, linux-kernel@...r.kernel.org, 
	linux-kselftest@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH v2] ww_mutex: convert self-test to KUnit

On Thu, Feb 13, 2025 at 6:59 AM Peter Zijlstra <peterz@...radead.org> wrote:
>
> On Thu, Feb 13, 2025 at 06:40:20AM -0500, Tamir Duberstein wrote:
> > Convert this unit test to a KUnit test. This allows the test to benefit
> > from the KUnit tooling. Note that care is taken to avoid test-ending
> > assertions in worker threads, which is unsafe in KUnit (and wasn't done
> > before this change either).
>
> So this was something simple, and now I need to know how to operate this
> kunit nonsense :-(
>
> How is that an improvement?

Hi Peter,

David enumerated some of the benefits of KUnit in another
thread: https://lore.kernel.org/all/CABVgOS=KZrM2dWyp1HzVS0zh7vquLxmTY2T2Ti53DQADrW+sJg@mail.gmail.com/.

My personal reason for preferring KUnit is that it's much easier to
run from userspace; the tooling takes care of building, starting the
VM, running the tests, and producing a human-friendly report.

Anecdotally I've seen evidence that e.g. Intel's 0-day runs all KUnit
tests but not all kselftests
(e.g. https://lore.kernel.org/all/202502090223.qCYMBjWT-lkp@intel.com/).



Tamir