linux-kernel - Re: [PATCH v3 3/4] kernel: globalize lookup_or_create_module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <450e8088-c239-4738-a996-834734f770a5@suse.com>
Date: Thu, 13 Feb 2025 16:59:25 +0100
From: Petr Pavlu <petr.pavlu@...e.com>
To: Shyam Saini <shyamsaini@...ux.microsoft.com>
Cc: linux-kernel@...r.kernel.org, linux-modules@...r.kernel.org,
 code@...icks.com, linux@...musvillemoes.dk, christophe.leroy@...roup.eu,
 hch@...radead.org, mcgrof@...nel.org, frkaya@...ux.microsoft.com,
 vijayb@...ux.microsoft.com, petr.pavlu@...e.com, linux@...ssschuh.net,
 samitolvanen@...gle.com, da.gomez@...sung.com, gregkh@...uxfoundation.org,
 rafael@...nel.org, dakr@...nel.org
Subject: Re: [PATCH v3 3/4] kernel: globalize
 lookup_or_create_module_kobject()

On 2/11/25 22:48, Shyam Saini wrote:
> lookup_or_create_module_kobject() is marked as static and __init,
> to make it global drop static keyword.
> Since this function can be called from non-init code, use __modinit
> instead of __init, __modinit marker will make it __init if
> CONFIG_MODULES is not defined.

Hm, we should later clean up kernel/params.c to use __init_or_module
from include/linux/module.h instead of its own __modinit implementation.

-- Petr