[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <173946420957.270661.16264499406247931837.b4-ty@kernel.org>
Date: Thu, 13 Feb 2025 22:00:09 +0530
From: Vinod Koul <vkoul@...nel.org>
To: Bard Liao <yung-chuan.liao@...ux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@...ux.dev>,
Sanyog Kale <sanyog.r.kale@...el.com>, linux-sound@...r.kernel.org,
linux-kernel@...r.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH] soundwire: Use str_enable_disable-like helpers
On Tue, 14 Jan 2025 21:07:26 +0100, Krzysztof Kozlowski wrote:
> Replace ternary (condition ? "enable" : "disable") syntax with helpers
> from string_choices.h because:
> 1. Simple function call with one argument is easier to read. Ternary
> operator has three arguments and with wrapping might lead to quite
> long code.
> 2. Is slightly shorter thus also easier to read.
> 3. It brings uniformity in the text - same string.
> 4. Allows deduping by the linker, which results in a smaller binary
> file.
>
> [...]
Applied, thanks!
[1/1] soundwire: Use str_enable_disable-like helpers
commit: 836c8a2edb96d78de6f00b60d6d8e24f2ea87e57
Best regards,
--
~Vinod
Powered by blists - more mailing lists