linux-kernel - Re: [PATCH] scripts/kernel-doc: remove an obscure logic from kernel-doc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wmdt6bv5.fsf@trenco.lwn.net>
Date: Thu, 13 Feb 2025 09:35:58 -0700
From: Jonathan Corbet <corbet@....net>
To: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>, Linux Doc Mailing
 List <linux-doc@...r.kernel.org>
Cc: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>, Mauro Carvalho Chehab
 <mchehab+huawei@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scripts/kernel-doc: remove an obscure logic from
 kernel-doc

Mauro Carvalho Chehab <mchehab+huawei@...nel.org> writes:

> Kernel-doc has an obscure logic that uses an external file
> to map files via a .tmp_filelist.txt file stored at the current
> directory. The rationale for such code predates git time,
> as it was added on Kernel v2.4.5.5, with the following description:
>
> 	# 26/05/2001 -         Support for separate source and object trees.
> 	#              Return error code.
> 	#              Keith Owens <kaos@....com.au>
>
> from commit 396a6123577d ("v2.4.5.4 -> v2.4.5.5") at the historic
> tree:
> 	https://git.kernel.org/pub/scm/linux/kernel/git/history/history.git/
>
> Support for separate source and object trees is now done on a different
> way via make O=<object>.
>
> There's no logic to create such file, so it sounds to me that this is
> just dead code.
>
> So, drop it.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
> ---
>  scripts/kernel-doc | 19 +------------------
>  1 file changed, 1 insertion(+), 18 deletions(-)

Weird ... I went and looked, and can't find anything that ever created
that tmp_filelist.txt file; I wonder if this code ever did anything?

Don't put that functionality into the Python version :)

Applied, thanks.

jon