linux-kernel - Re: [PATCH v3 2/2] arm64: dts: qcom: sa8775p-ride: Enable Adreno 663 GPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0b659aed-4b4a-45d5-a388-ebea22d17bc4@quicinc.com>
Date: Thu, 13 Feb 2025 22:21:52 +0530
From: Akhil P Oommen <quic_akhilpo@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
CC: Rob Clark <robdclark@...il.com>, Sean Paul <sean@...rly.run>,
        "Konrad
 Dybcio" <konradybcio@...nel.org>,
        Abhinav Kumar <quic_abhinavk@...cinc.com>,
        Marijn Suijten <marijn.suijten@...ainline.org>,
        David Airlie
	<airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
        Maarten Lankhorst
	<maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Connor Abbott <cwabbott0@...il.com>, <linux-arm-msm@...r.kernel.org>,
        <dri-devel@...ts.freedesktop.org>, <freedreno@...ts.freedesktop.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        Puranam V G Tejaswi <quic_pvgtejas@...cinc.com>
Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: sa8775p-ride: Enable Adreno 663
 GPU

On 2/12/2025 4:26 PM, Dmitry Baryshkov wrote:
> On Wed, Feb 12, 2025 at 12:48:01PM +0530, Akhil P Oommen wrote:
>> On 2/12/2025 5:30 AM, Dmitry Baryshkov wrote:
>>> On Tue, Feb 11, 2025 at 06:41:39PM +0530, Akhil P Oommen wrote:
>>>> On 2/9/2025 9:59 PM, Dmitry Baryshkov wrote:
>>>>> On Wed, Nov 13, 2024 at 02:18:43AM +0530, Akhil P Oommen wrote:
>>>>>> On 10/30/2024 12:32 PM, Akhil P Oommen wrote:
>>>>>>> From: Puranam V G Tejaswi <quic_pvgtejas@...cinc.com>
>>>>>>>
>>>>>>> Enable GPU for sa8775p-ride platform and provide path for zap
>>>>>>> shader.
>>>>>>>
>>>>>>> Signed-off-by: Puranam V G Tejaswi <quic_pvgtejas@...cinc.com>
>>>>>>> Signed-off-by: Akhil P Oommen <quic_akhilpo@...cinc.com>
>>>>>>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
>>>>>>> ---
>>>>>>>  arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 8 ++++++++
>>>>>>>  1 file changed, 8 insertions(+)
>>>>>>>
>>>>>>> diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
>>>>>>> index 0c1b21def4b6..4901163df8f3 100644
>>>>>>> --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
>>>>>>> +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
>>>>>>> @@ -407,6 +407,14 @@ queue3 {
>>>>>>>  	};
>>>>>>>  };
>>>>>>>  
>>>>>>> +&gpu {
>>>>>>> +	status = "okay";
>>>>>>> +};
>>>>>>> +
>>>>>>> +&gpu_zap_shader {
>>>>>>> +	firmware-name = "qcom/sa8775p/a663_zap.mbn";
>>>>>>> +};
>>>>>>> +
>>>>>>>  &i2c11 {
>>>>>>>  	clock-frequency = <400000>;
>>>>>>>  	pinctrl-0 = <&qup_i2c11_default>;
>>>>>>>
>>>>>>
>>>>>> Bjorn,
>>>>>>
>>>>>> Please ignore this patch for now. This is probably not the right
>>>>>> platform dtsi file where gpu should be enabled. I am discussing about
>>>>>> this internally. Will send a revision or a new patch based on the
>>>>>> conclusion.
>>>>>
>>>>> Akhil, any updates on this?
>>>>>
>>>>
>>>> I am still waiting for the discussion about QCS9075 board dts files [1]
>>>> to conclude.
>>>>
>>>> [1]
>>>> https://lore.kernel.org/lkml/Z3eMxl1Af8TOAQW%2F@hu-wasimn-hyd.qualcomm.com/T/
>>>
>>> Why? We currently have several boards supported. We can enable GPU on
>>> those as your patches are pretty fine. Then we can land Wasim's patches.
>>> Not to mention that the discussion seems to be dead, last message was
>>> sent almost a month ago.
>>>
>>
>> sa8775p is an automotive-grade chipset which has a pretty different
>> non-HLOS firmware. One of the major difference is that it has a SAFETY
>> monitoring system (using SAIL IP block) which monitors different
>> parameters like GPU frequency for eg and it takes control of the entire
>> system when it detects an anomaly. That means we cannot use GPU DCVS,
>> passive thermal mitigation etc there.
>>
>> QCS9075 uses the same SoC but has different NHLOS firmwares that has
>> SAIL disabled to make it behave like our regular chipsets. I am aware of
>> only QCS9075 boards' GPU spec at the moment. I don't know the complete
>> details of the impact of SAIL/SAFE features on GPU and other specs yet,
>> so I can't disturb sa8775p-ride/qcs9100-ride boards.
> 
> Ack, thanks for the explanation. Indeed, it would be interesting to
> understand how that's working together. Do SA8775P / QCS9100 use a
> different GMU firmware?

We don't have a linux compatible GMU firmware for SA8775P yet. But it
will be a common gmu fw between all three platforms.

-Akhil.

> 
>> I can see that Wazim is still discussing about board DTS internally.
>> Hopefully he will send out another revision of his series soon.
> 
> The discussion stopped a month ago. 
>