linux-kernel - Re: [PATCH 1/1] cxl/pmem: debug invalid serial number data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z64iEJB6l8xhDsGj@aschofie-mobl2.lan>
Date: Thu, 13 Feb 2025 08:47:12 -0800
From: Alison Schofield <alison.schofield@...el.com>
To: Yuquan Wang <wangyuquan1236@...tium.com.cn>
Cc: dave@...olabs.net, jonathan.cameron@...wei.com, dave.jiang@...el.com,
	vishal.l.verma@...el.com, ira.weiny@...el.com,
	dan.j.williams@...el.com, linux-cxl@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] cxl/pmem: debug invalid serial number data

On Thu, Feb 13, 2025 at 02:40:08PM +0800, Yuquan Wang wrote:
> In a nvdimm interleave-set each device with an invalid or zero
> serial number may cause pmem region initialization to fail, but in
> cxl case such device could still set cookies of nd_interleave_set
> and create a nvdimm pmem region.
> 
> This adds the validation of serial number in cxl pmem region creation.
> The event of no serial number would cause to fail to set the cookie
> and pmem region.

This trips up cxl-test where a mock serial number is set from the
platform device id and 0 is a valid platform device id.

Take a look at doing this cxl_mock_mem_probe():
-       cxlds->serial = pdev->id;
+       cxlds->serial = pdev->id + 1;

--snip