[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAH4c4j+kOYMfzO5QOBg+hGe2zt4kN4f7v+mrri-2GMLzYtCPrw@mail.gmail.com>
Date: Thu, 13 Feb 2025 23:05:39 +0530
From: Pranav Tyagi <pranav.tyagi03@...il.com>
To: Bagas Sanjaya <bagasdotme@...il.com>
Cc: Linux Documentation <linux-doc@...r.kernel.org>,
Linux DRI Development <dri-devel@...ts.freedesktop.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linux-kernel-mentees@...ts.linux.dev,
skhan@...uxfoundation.org, David Airlie <airlied@...il.com>,
Simona Vetter <simona@...ll.ch>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
Jonathan Corbet <corbet@....net>
Subject: Re: [PATCH] vgaarbiter: documentation grammar correction
Hi,
Just a gentle follow-up on this patch. It has been reviewed but hasn't
been applied yet.
Regards
Pranav Tyagi
On Thu, Feb 13, 2025 at 10:54 PM Pranav Tyagi <pranav.tyagi03@...il.com> wrote:
>
> Hi,
>
> Just a gentle follow-up on this patch. It has been reviewed by Bagas Sanjaya but hasn't been applied yet.
>
> Regards,
>
> Pranav Tyagi
>
>
> On Sat, Feb 8, 2025 at 8:36 AM Bagas Sanjaya <bagasdotme@...il.com> wrote:
>>
>> On Fri, Feb 07, 2025 at 10:23:25PM +0530, Pranav Tyagi wrote:
>> > Corrects the following grammatical issues in the VGA Arbiter documentation:
>> > - Fixes subject-verb agreement by changing "co-exists" to "co-exist"
>> > - Corrects pluralization by changing "server" to "servers"
>> > - Improves sentence structure for clarity
>> >
>>
>> +Cc: DRM folks.
>>
>> > Signed-off-by: Pranav Tyagi <pranav.tyagi03@...il.com>
>> > ---
>> > Documentation/gpu/vgaarbiter.rst | 6 +++---
>> > 1 file changed, 3 insertions(+), 3 deletions(-)
>> >
>> > diff --git a/Documentation/gpu/vgaarbiter.rst b/Documentation/gpu/vgaarbiter.rst
>> > index bde3c0afb059..d1e953712cc2 100644
>> > --- a/Documentation/gpu/vgaarbiter.rst
>> > +++ b/Documentation/gpu/vgaarbiter.rst
>> > @@ -11,9 +11,9 @@ Section 7, Legacy Devices.
>> >
>> > The Resource Access Control (RAC) module inside the X server [0] existed for
>> > the legacy VGA arbitration task (besides other bus management tasks) when more
>> > -than one legacy device co-exists on the same machine. But the problem happens
>> > +than one legacy device co-exist on the same machine. But the problem happens
>> > when these devices are trying to be accessed by different userspace clients
>> > -(e.g. two server in parallel). Their address assignments conflict. Moreover,
>> > +(e.g. two servers in parallel). Their address assignments conflict. Moreover,
>> > ideally, being a userspace application, it is not the role of the X server to
>> > control bus resources. Therefore an arbitration scheme outside of the X server
>> > is needed to control the sharing of these resources. This document introduces
>> > @@ -106,7 +106,7 @@ In-kernel interface
>> > libpciaccess
>> > ------------
>> >
>> > -To use the vga arbiter char device it was implemented an API inside the
>> > +To use the vga arbiter char device, an API was implemented inside the
>> > libpciaccess library. One field was added to struct pci_device (each device
>> > on the system)::
>> >
>>
>> The diff looks OK.
>>
>> Reviewed-by: Bagas Sanjaya <bagasdotme@...il.com>
>>
>> --
>> An old man doll... just what I always wanted! - Clara
Powered by blists - more mailing lists