linux-kernel - Re: [PATCH v6 00/14] Add eDP support for RK3588

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m3ovwhg3h2njsjpuj2wdahxex6zq2udmxonublgmnlrdfred4z@zxtyd6xvhram>
Date: Thu, 13 Feb 2025 18:33:04 +0100
From: Sebastian Reichel <sebastian.reichel@...labora.com>
To: Diederik de Haas <didi.debian@...ow.org>
Cc: Piotr Oniszczuk <piotr.oniszczuk@...il.com>, 
	Damon Ding <damon.ding@...k-chips.com>, heiko@...ech.de, robh@...nel.org, conor+dt@...nel.org, 
	algea.cao@...k-chips.com, rfoss@...nel.org, devicetree@...r.kernel.org, 
	linux-phy@...ts.infradead.org, linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	dri-devel@...ts.freedesktop.org, hjc@...k-chips.com, kever.yang@...k-chips.com, 
	dmitry.baryshkov@...aro.org, vkoul@...nel.org, andy.yan@...k-chips.com, krzk+dt@...nel.org, 
	linux-arm-kernel@...ts.infradead.org, l.stach@...gutronix.de
Subject: Re: [PATCH v6 00/14] Add eDP support for RK3588

Hi,

On Thu, Feb 13, 2025 at 05:56:55PM +0100, Diederik de Haas wrote:
> On Thu Feb 13, 2025 at 3:54 PM CET, Piotr Oniszczuk wrote:
> >
> >
> >> Wiadomość napisana przez Damon Ding <damon.ding@...k-chips.com> w dniu 23 sty 2025, o godz. 11:07:
> >> 
> >> Picked from:
> >> https://patchwork.kernel.org/project/linux-rockchip/list/?series=923593
> >> 
> >> These patchs have been tested with a 1536x2048p60 eDP panel on
> >> RK3588S EVB1 board, and HDMI 1080P/4K display also has been verified
> >> on RK3588 EVB1 board. Furthermore, the eDP display has been rechecked
> >> on RK3399 sapphire excavator board.
> >> ...
> >> 9 files changed, 401 insertions(+), 89 deletions(-)
> >> 
> >> -- 
> >> 2.34.1
> >> 
> >
> > Damon,
> >
> > I’m playing with hdmi0 port enablement on radxa rock5 itx board with 6.14 mainline.
> >
> > rock5 itx has 2 hdmi ports: hdmi0 is wired to rk3588 typeC1/eDP1 eDP with ra620 eDP->HDMI converter and hdmi1 from hdmi/edp tx1
> > (see page3 & page29 at https://dl.radxa.com/rock5/5itx/v1110/radxa_rock_5itx_v1110_schematic.pdf)
> >
> > I’m on 6.14-rc2 with applied: 
> > [1] Cristicc hdmi code (https://gitlab.collabora.com/cristicc/linux-next/-/commits/rk3588-hdmi-bridge)
> > [2] eDP support for RK3588 (https://patchwork.kernel.org/project/linux-rockchip/list/?series=927765)
> > [3] Add eDP mode support for Rockchip Samsung HDPTX PHY (https://patchwork.kernel.org/project/linux-rockchip/cover/20250205105157.580060-1-damon.ding@rock-chips.com/)
> >
> > Is edp1 supported by yours [2] series?
> >
> > If yes - may you pls hint me about required dts additions in https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts?h=v6.14-rc2 ?
> 
> I don't know if it's relevant, but while HDMI0 got enabled for quite a
> few devices in 6.13, it did NOT get enabled for Rock 5 ITX.
> I made a local patch (which does the same thing as was done for Rock 5B)
> but I have no idea if it actually works (I don't have the board).

I don't have the board either, but the schematics suggests that your
patch is not correct. On the Rock 5 ITX the RK3588's first HDMI/eDP
port should be enabled in eDP mode to be used with an eDP panel via
connector J11. This series is needed for that.

Greetings,

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)