linux-kernel - Re: [PATCH v1 1/1] gpiolib: Fix crash on error in gpiochip_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <173946910471.103328.15879117296822484780.b4-ty@linaro.org>
Date: Thu, 13 Feb 2025 18:52:05 +0100
From: Bartosz Golaszewski <brgl@...ev.pl>
To: linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>
Subject: Re: [PATCH v1 1/1] gpiolib: Fix crash on error in gpiochip_get_ngpios()

From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>


On Thu, 13 Feb 2025 17:56:46 +0200, Andy Shevchenko wrote:
> The gpiochip_get_ngpios() uses chip_*() macros to print messages.
> However these macros rely on gpiodev to be initialised and set,
> which is not the case when called via bgpio_init(). In such a case
> the printing messages will crash on NULL pointer dereference.
> Replace chip_*() macros by the respective dev_*() ones to avoid
> such crash.
> 
> [...]

Eeek! Good catch, queued for fixes.

Bart

[1/1] gpiolib: Fix crash on error in gpiochip_get_ngpios()
      commit: 7b4aebeecbbd5b5fe73e35fad3f62ed21aa7ef44

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@...aro.org>