linux-kernel - Re: [PATCH] block: Modify the escape character

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f5182f1c-eec9-9144-114c-1bdbd2571990@huaweicloud.com>
Date: Thu, 13 Feb 2025 11:38:21 +0800
From: Yu Kuai <yukuai1@...weicloud.com>
To: Donglei Wei <veidongray@...com>, linux-block@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH] block: Modify the escape character

Hi,

Please change the title.

在 2025/02/09 20:35, Donglei Wei 写道:
>      The iocg->cfg_weight/WEIGHT_ONE code has a data type of long unsigned int,
>      which is escaped using %u, which generates a compilation warning.
> 
>      Signed-off-by: Donglei Wei <veidongray@...com>
> ---

I never see this warning, is this because USEC_PER_MSEC is long, causing
other fields in the same enum to be long?

Thanks,
Kuai

>   block/blk-iocost.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/block/blk-iocost.c b/block/blk-iocost.c
> index 65a1d4427ccf..693e642d4235 100644
> --- a/block/blk-iocost.c
> +++ b/block/blk-iocost.c
> @@ -3078,7 +3078,7 @@ static u64 ioc_weight_prfill(struct seq_file *sf, struct blkg_policy_data *pd,
>   	struct ioc_gq *iocg = pd_to_iocg(pd);
>   
>   	if (dname && iocg->cfg_weight)
> -		seq_printf(sf, "%s %u\n", dname, iocg->cfg_weight / WEIGHT_ONE);
> +		seq_printf(sf, "%s %lu\n", dname, iocg->cfg_weight / WEIGHT_ONE);
>   	return 0;
>   }
>   
> @@ -3088,7 +3088,7 @@ static int ioc_weight_show(struct seq_file *sf, void *v)
>   	struct blkcg *blkcg = css_to_blkcg(seq_css(sf));
>   	struct ioc_cgrp *iocc = blkcg_to_iocc(blkcg);
>   
> -	seq_printf(sf, "default %u\n", iocc->dfl_weight / WEIGHT_ONE);
> +	seq_printf(sf, "default %lu\n", iocc->dfl_weight / WEIGHT_ONE);
>   	blkcg_print_blkgs(sf, blkcg, ioc_weight_prfill,
>   			  &blkcg_policy_iocost, seq_cft(sf)->private, false);
>   	return 0;
>