linux-kernel - Re: [PATCH net-next 1/7] net: hibmcge: Add dump statistics supported in this module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47e8bab3-61cb-4c5a-9b40-03011b6267b3@lunn.ch>
Date: Thu, 13 Feb 2025 20:54:50 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Jijie Shao <shaojijie@...wei.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
	shenjian15@...wei.com, wangpeiyang1@...wei.com,
	liuyonglong@...wei.com, chenhao418@...wei.com,
	sudongming1@...wei.com, xujunsheng@...wei.com,
	shiyongbang@...wei.com, libaihan@...wei.com,
	jonathan.cameron@...wei.com, shameerali.kolothum.thodi@...wei.com,
	salil.mehta@...wei.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 1/7] net: hibmcge: Add dump statistics supported
 in this module

On Thu, Feb 13, 2025 at 11:55:23AM +0800, Jijie Shao wrote:
> The driver supports many hw statistics. This patch supports
> dump statistics through ethtool_ops and ndo.get_stats64().
> 
> The type of hw statistics register is u32,
> To prevent the statistics register from overflowing,
> the driver dump the statistics every 5 minutes
> in a scheduled task.

u32 allows the counter to reach 4294967295 before wrapping. So over 5
minutes, that is around 14,316,557 per second. Say this is your
received byte counter? That means your line rate cannot be higher than
114Mbps? Is this device really only Fast Ethernet?

	 Andrew