linux-kernel - Re: [PATCH v2] scsi: hpsa: Replace deprecated strncpy() with strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202502131218.B53CB1EB@keescook>
Date: Thu, 13 Feb 2025 12:19:46 -0800
From: Kees Cook <kees@...nel.org>
To: Bart Van Assche <bvanassche@....org>
Cc: Thorsten Blum <thorsten.blum@...ux.dev>,
	Don Brace <don.brace@...rochip.com>,
	"James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	linux-hardening@...r.kernel.org, storagedev@...rochip.com,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] scsi: hpsa: Replace deprecated strncpy() with
 strscpy_pad()

On Thu, Feb 13, 2025 at 10:24:25AM -0800, Bart Van Assche wrote:
> On 2/13/25 3:40 AM, Thorsten Blum wrote:
> > diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
> > index c7ebae24b09f..968cefb497eb 100644
> > --- a/drivers/scsi/hpsa.c
> > +++ b/drivers/scsi/hpsa.c
> > @@ -7236,8 +7236,7 @@ static int hpsa_controller_hard_reset(struct pci_dev *pdev,
> >   static void init_driver_version(char *driver_version, int len)
> >   {
> > -	memset(driver_version, 0, len);
> > -	strncpy(driver_version, HPSA " " HPSA_DRIVER_VERSION, len - 1);
> > +	strscpy_pad(driver_version, HPSA " " HPSA_DRIVER_VERSION, len);
> >   }
> >   static int write_driver_ver_to_cfgtable(struct CfgTable __iomem *cfgtable)
> 
> Has it been considered to introduce a Coccinelle semantic patch that
> performs this conversion? See also the scripts/coccinelle directory.

Using this:

@pad0 depends on !(file in "tools") && !(file in "samples")@
expression DEST, SRC;
expression LENGTH;
@@

-     memset(DEST, 0, LENGTH);
-     strncpy(DEST, SRC, LENGTH - 1);
+     strscpy_pad(DEST, SRC, LENGTH);

@padNUL depends on !(file in "tools") && !(file in "samples")@
expression DEST, SRC;
expression LENGTH;
@@

-     memset(DEST, '\0', LENGTH);
-     strncpy(DEST, SRC, LENGTH - 1);
+     strscpy_pad(DEST, SRC, LENGTH);

It turns out this is the only place left in the kernel using that
pattern. :)

> 
> Anyway:
> 
> Reviewed-by: Bart Van Assche <bvanassche@....org>

Reviewed-by: Kees Cook <kees@...nel.org>

-- 
Kees Cook