linux-kernel - Re: [PATCH] EDAC: Use string choice helper functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250213210510.GA212119@yaz-khff2.amd.com>
Date: Thu, 13 Feb 2025 16:05:10 -0500
From: Yazen Ghannam <yazen.ghannam@....com>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: Borislav Petkov <bp@...en8.de>, Tony Luck <tony.luck@...el.com>,
	James Morse <james.morse@....com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Robert Richter <rric@...nel.org>,
	Khuong Dinh <khuong@...amperecomputing.com>,
	linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] EDAC: Use string choice helper functions

On Thu, Feb 13, 2025 at 09:10:28PM +0100, Thorsten Blum wrote:
> On 13. Feb 2025, at 18:41, Yazen Ghannam wrote:
> > On Sun, Feb 09, 2025 at 10:52:21PM +0100, Thorsten Blum wrote:
> >> Remove hard-coded strings by using the str_enabled_disabled(),
> >> str_yes_no(), str_write_read(), and str_plural() helper functions.
> >> 
> >> Add a space in "All DIMMs support ECC: yes/no" to improve readability.
> >> 
> >> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> >> ---
> >> drivers/edac/amd64_edac.c | 47 +++++++++++++++++++--------------------
> >> drivers/edac/debugfs.c    |  5 ++++-
> >> drivers/edac/i5400_edac.c |  3 ++-
> >> drivers/edac/i7300_edac.c |  7 +++---
> >> drivers/edac/xgene_edac.c | 17 +++++++-------
> >> 5 files changed, 42 insertions(+), 37 deletions(-)
> >> 
> > 
> > Please do include a base commit id. This patch doesn't apply to
> > ras/edac-for-next but does apply to mainline/master.
> 
> Ok. Should I rebase and resubmit or just for next time?

Just for next time I think.

> 
> > Is there any effort to make folks aware of these helpers? Maybe an
> > addition to checkpatch (as a CHECK/suggestion)?
> 
> Not that I'm aware of. However, there is a Coccinelle/coccicheck script
> in scripts/coccinelle/api/string_choices.cocci.
> 

Cool, thanks. I'll check it out.

Thanks,
Yazen