linux-kernel - Re: [PATCH v2] i2c: pxa: fix call balance of i2c->clk handling routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <novywnbf7giauswdm7lt5n6cwjwchhxsvmixv5m7qurcb25wo6@4ajvllzecbra>
Date: Thu, 13 Feb 2025 23:33:22 +0100
From: Andi Shyti <andi.shyti@...nel.org>
To: Vitalii Mordan <mordan@...ras.ru>
Cc: Russell King <rmk@...-67.arm.linux.org.uk>, linux-i2c@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Fedor Pchelkin <pchelkin@...ras.ru>, 
	Alexey Khoroshilov <khoroshilov@...ras.ru>, Vadim Mutilin <mutilin@...ras.ru>, lvc-project@...uxtesting.org
Subject: Re: [PATCH v2] i2c: pxa: fix call balance of i2c->clk handling
 routines

Hi Vitalii,

On Wed, Feb 12, 2025 at 08:28:03PM +0300, Vitalii Mordan wrote:
> If the clock i2c->clk was not enabled in i2c_pxa_probe(), it should not be
> disabled in any path.
> 
> Found by Linux Verification Center (linuxtesting.org) with Klever.

here I added a blank line.

> Signed-off-by: Vitalii Mordan <mordan@...ras.ru>

...

> -	clk_prepare_enable(i2c->clk);
> +	ret = clk_prepare_enable(i2c->clk);
> +	if (ret) {
> +		return dev_err_probe(&dev->dev, ret,
> +				     "failed to enable clock\n");
> +	}

I removed the brackets here that are not necessary.

Merged to i2c/i2c-host.

Thanks,
Andi

>  
>  	if (i2c->use_pio) {
>  		i2c->adap.algo = &i2c_pxa_pio_algorithm;
> -- 
> 2.25.1
>