linux-kernel - Re: [PATCH] x86/efistub: Add options for forcing Apple set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z617aePOV7Vj_ffv@wunner.de>
Date: Thu, 13 Feb 2025 05:56:09 +0100
From: Lukas Wunner <lukas@...ner.de>
To: Aditya Garg <gargaditya08@...e.com>
Cc: Lleyton Gray <lleyton@...alabs.com>, Ard Biesheuvel <ardb@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>
Subject: Re: [PATCH] x86/efistub: Add options for forcing Apple set_os
 protocol

On Tue, Feb 11, 2025 at 04:05:12PM +0000, Aditya Garg wrote:
> > On 11 Feb 2025, at 1:28AM, Lukas Wunner <lukas@...ner.de> wrote:
> > FWIW, below would be my suggestion for replacing the DMI-based quirk
> > with one that is based on the number of GPUs.
> > 
> > It should invoke the apple_set_os protocol both on dual GPU laptops
> > as well as ones with an eGPU, hence my expectation is that it should
> > fix the issue reported by Lleyton.
> 
> This patch does not enable the os set protocol on my MacBook Pro 16 inch 2019
> 
> journalctl -k: https://pastebin.com/7etWy0D5

Hm, perhaps Apple's EFI disables the iGPU by default and re-enables it
upon the set_os protocol call.  Or I've botched the patch, but I just
double-checked the logic and it seems fine to me.

Could somebody with an eGPU test whether the patch results in the
expected invocation of set_os (and thus a working eGPU)?

If it does, we'd just have to keep apple_match_product_name() as an
alternative condition under which set_os is called.

Thanks,

Lukas