linux-kernel - Re: [RFC PATCH 1/3] dt-bindings: media: cdns,csi2rx.yaml: Add optional interrupts for cdns-csi2rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <94112ab7-5462-4a5b-90f3-636a7f8e5989@ti.com>
Date: Thu, 13 Feb 2025 12:46:03 +0530
From: Yemike Abhilash Chandra <y-abhilashchandra@...com>
To: Krzysztof Kozlowski <krzk@...nel.org>, <linux-media@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>
CC: <mripard@...nel.org>, <mchehab@...nel.org>, <jai.luthra@...ux.dev>,
        <robh@...nel.org>, <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
        <devarsht@...com>, <vaishnav.a@...com>, <r-donadkar@...com>,
        <u-kumar1@...com>
Subject: Re: [RFC PATCH 1/3] dt-bindings: media: cdns,csi2rx.yaml: Add
 optional interrupts for cdns-csi2rx


On 13/02/25 00:58, Krzysztof Kozlowski wrote:
> On 12/02/2025 14:12, Yemike Abhilash Chandra wrote:
>> The Cadence CSI2RX IP exposes 3 interrupts [0] 12.7 camera subsystem.
>> Enabling these interrupts will provide additional information about a CSI
>> packet or an individual frame. So, add support for optional interrupts
>> and interrupt-names properties.
>>
>> [0]: http://www.ti.com/lit/pdf/spruil1
> 
> 
> Why is this RFC?
>

I sent this as an RFC to gather input from different vendors using the 
cdns,csi2rx driver
and its device tree bindings. so I just wanted to get their feedback as 
well.
If there are no concerns from any of the them, I will proceed with 
sending this as v1.

>>
>> Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@...com>
>> ---
>>   .../devicetree/bindings/media/cdns,csi2rx.yaml        | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/media/cdns,csi2rx.yaml b/Documentation/devicetree/bindings/media/cdns,csi2rx.yaml
>> index 2008a47c0580..a3acf4f861c2 100644
>> --- a/Documentation/devicetree/bindings/media/cdns,csi2rx.yaml
>> +++ b/Documentation/devicetree/bindings/media/cdns,csi2rx.yaml
>> @@ -24,6 +24,17 @@ properties:
>>     reg:
>>       maxItems: 1
>>   
>> +  interrupts:
>> +    minItems: 1
>> +    maxItems: 3
> 
> I understand interrupts might be unused by driver, but are you sure they
> are optionally connected one-by-one? IOW, why is this flexible?
> 

I understand that this flexibility is not needed, and I will correct
that while sending v1.

Thanks and Regards,
Yemike Abhilash Chandra

> 
> Best regards,
> Krzysztof