linux-kernel - Re: [PATCH v3 2/2] serial: tegra-utc: Add driver for Tegra UART Trace Controller (UTC)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f3e6958-25eb-4835-88e1-2d531c892dbe@kernel.org>
Date: Thu, 13 Feb 2025 08:38:15 +0100
From: Jiri Slaby <jirislaby@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Kartik Rajput <kkartik@...dia.com>
Cc: gregkh@...uxfoundation.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, thierry.reding@...il.com, jonathanh@...dia.com,
 hvilleneuve@...onoff.com, arnd@...nel.org, geert+renesas@...der.be,
 robert.marko@...tura.hr, schnelle@...ux.ibm.com,
 linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
 devicetree@...r.kernel.org, linux-tegra@...r.kernel.org
Subject: Re: [PATCH v3 2/2] serial: tegra-utc: Add driver for Tegra UART Trace
 Controller (UTC)

On 12. 02. 25, 16:09, Andy Shevchenko wrote:
>> +static bool tegra_utc_tx_chars(struct tegra_utc_port *tup)
>> +{
>> +	struct uart_port *port = &tup->port;
>> +	unsigned int pending;
>> +	u8 c;
>> +
>> +	pending = uart_port_tx(port, c,
>> +		     !(tegra_utc_tx_readl(tup, TEGRA_UTC_FIFO_STATUS) & TEGRA_UTC_FIFO_FULL),
>> +		     tegra_utc_tx_writel(tup, c, TEGRA_UTC_DATA));
> 
> Make the last two to reside in temporary variables with self-explanatory names.

Not sure what you mean here? They are needed to be evaluated 
(read/written) in every loop.

-- 
js
suse labs