linux-kernel - Re: [PATCH v2 2/3] usb: dwc3: gadget: Add support for snps,reserved-endpoints property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z62nLY_m_FG1Phc7@smile.fi.intel.com>
Date: Thu, 13 Feb 2025 10:02:53 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Thinh Nguyen <Thinh.Nguyen@...opsys.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Felipe Balbi <balbi@...nel.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Ferry Toth <fntoth@...il.com>
Subject: Re: [PATCH v2 2/3] usb: dwc3: gadget: Add support for
 snps,reserved-endpoints property

On Thu, Feb 13, 2025 at 01:16:15AM +0000, Thinh Nguyen wrote:
> On Wed, Feb 12, 2025, Andy Shevchenko wrote:
> > On Wed, Feb 12, 2025 at 01:10:17AM +0000, Thinh Nguyen wrote:
> > > On Mon, Feb 03, 2025, Andy Shevchenko wrote:

...

> > > >  	/* Reset resource allocation flags */
> > > > -	for (i = resource_index; i < dwc->num_eps && dwc->eps[i]; i++)
> > > > -		dwc->eps[i]->flags &= ~DWC3_EP_RESOURCE_ALLOCATED;
> > > > +	for (i = resource_index; i < dwc->num_eps; i++) {
> > > > +		dep = dwc->eps[i];
> > > > +		if (!dep)
> > > > +			continue;
> > > > +
> > > > +		dep->flags &= ~DWC3_EP_RESOURCE_ALLOCATED;
> > > > +	}
> > > 
> > > Please keep code refactoring as a separate patch.
> > 
> > It's induced by the change you asked for, it's not a simple refactoring.
> > 
> > Or do you want me to have the patch to check eps against NULL to be separated
> > from this one (see (1) above)?
> 
> The condition "i < dwc->num && dwc->eps[i]" already does the NULL check.
> The change here only move things around.

Yes, but the problem is that the loop will stop on the first gap, but we would
like to continue.

> > > >  	return 0;

-- 
With Best Regards,
Andy Shevchenko