linux-kernel - Re: [PATCH] media: dt-bindings: Convert Analog Devices ad5820 to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250213-tough-mink-of-freedom-2acd95@krzk-bin>
Date: Thu, 13 Feb 2025 09:40:42 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: David Heidelberg <david@...t.cz>
Cc: Pavel Machek <pavel@....cz>, 
	Sakari Ailus <sakari.ailus@...ux.intel.com>, Mauro Carvalho Chehab <mchehab@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, linux-media@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: dt-bindings: Convert Analog Devices ad5820 to DT
 schema

On Sun, Feb 09, 2025 at 09:39:25PM +0100, David Heidelberg wrote:
> Convert the Analog Devices ad5820 to DT schema format.
> 
> Signed-off-by: David Heidelberg <david@...t.cz>
> ---
> Needs: media: dt-bindings: media: i2c: align filenames format with standard

Well, it shouldn't. No need to rename the TXT file if you are going to
remove it in other patch,

> 
>  .../bindings/media/i2c/adi,ad5820.txt         | 28 ---------
>  .../bindings/media/i2c/adi,ad5820.yaml        | 62 +++++++++++++++++++
>  2 files changed, 62 insertions(+), 28 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/media/i2c/adi,ad5820.txt
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/adi,ad5820.yaml
> 

...

> +  reg:
> +    maxItems: 1
> +
> +  enable-gpios:
> +    maxItems: 1
> +    description:
> +      GPIO spec for the XSHUTDOWN pin. The XSHUTDOWN signal is active low,
> +      a high level on the pin enables the device.
> +
> +  VANA-supply:
> +    description: supply of voltage for VANA pin
> +
> +  "#io-channel-cells":
> +    const: 0

This wasn't in original binding, so needs explanation why in the commit
msg.

> +
> +required:
> +  - compatible
> +  - reg
> +  - VANA-supply
> +  - '#io-channel-cells'

use consistent quotes, either ' or "

> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    i2c {
> +            #address-cells = <1>;

Use 4 spaces for example indentation.

Best regards,
Krzysztof