linux-kernel - Re: [PATCH next v2 1/3] dt-bindings: usb: microchip,usb2514: add support for vdda

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b0df1565-46a5-415e-b01f-822762c523b4@leica-geosystems.com>
Date: Thu, 13 Feb 2025 09:41:00 +0000
From: POPESCU Catalin <catalin.popescu@...ca-geosystems.com>
To: Conor Dooley <conor@...nel.org>
CC: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"festevam@...il.com" <festevam@...il.com>, "linux-usb@...r.kernel.org"
	<linux-usb@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "m.felsch@...gutronix.de"
	<m.felsch@...gutronix.de>, GEO-CHHER-bsp-development
	<bsp-development.geo@...ca-geosystems.com>
Subject: Re: [PATCH next v2 1/3] dt-bindings: usb: microchip,usb2514: add
 support for vdda

On 12/02/2025 20:14, Conor Dooley wrote:
> On Wed, Feb 12, 2025 at 02:56:47PM +0100, Catalin Popescu wrote:
>> Microchip hub USB2514 has one 3V3 digital power supply and one 3V3
>> analog power supply. Add support for analog power supply vdda.
>>
>> Signed-off-by: Catalin Popescu <catalin.popescu@...ca-geosystems.com>
>> ---
>> v2:
>> - merge "if" with "allOf" and move the whole after patternProperties
>>    section
>> ---
>>   .../bindings/usb/microchip,usb2514.yaml       | 21 ++++++++++++++++---
>>   1 file changed, 18 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
>> index b14e6f37b298..aeffdf0362c2 100644
>> --- a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
>> +++ b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
>> @@ -9,9 +9,6 @@ title: Microchip USB2514 Hub Controller
>>   maintainers:
>>     - Fabio Estevam <festevam@...il.com>
>>   
>> -allOf:
>> -  - $ref: usb-device.yaml#
>> -
>>   properties:
>>     compatible:
>>       enum:
>> @@ -28,6 +25,9 @@ properties:
>>     vdd-supply:
>>       description: 3.3V power supply.
>>   
>> +  vdda-supply:
>> +    description: 3.3V analog power supply.
>> +
>>     clocks:
>>       description: External 24MHz clock connected to the CLKIN pin.
>>       maxItems: 1
>> @@ -43,6 +43,20 @@ patternProperties:
>>       $ref: /schemas/usb/usb-device.yaml
>>       additionalProperties: true
>>   
>> +allOf:
>> +  - $ref: usb-device.yaml#
>> +  - if:
>> +      properties:
>> +        compatible:
>> +          contains:
>> +            const: usb424,2514
>> +    then:
>> +      properties:
>> +        vdda-supply: true
>> +    else:
>> +      properties:
>> +        vdda-supply: false
> Hmm, the then: here isn't needed, you can just invert the original if
> with a "not:". Sorry for not noticing that last time.

Sure, no problem.
BR,