linux-kernel - Re: [PATCH] ALSA: hda: Add error check for snd_ctl_rename_id() in snd_hda_create_dig_out

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025021323-paparazzi-ahead-22ec@gregkh>
Date: Thu, 13 Feb 2025 10:47:36 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Markus Elfring <Markus.Elfring@....de>
Cc: vulab@...as.ac.cn, linux-sound@...r.kernel.org, stable@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	Cezary Rojewski <cezary.rojewski@...el.com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Julia Lawall <Julia.Lawall@...ia.fr>, Takashi Iwai <tiwai@...e.com>
Subject: Re: [PATCH] ALSA: hda: Add error check for snd_ctl_rename_id() in
 snd_hda_create_dig_out_ctls()

On Thu, Feb 13, 2025 at 08:26:09AM +0100, Markus Elfring wrote:
> > Check the return value of snd_ctl_rename_id() in
> > snd_hda_create_dig_out_ctls(). Ensure that potential
> > failures are properly handled.
> 
> I would prefer a change description variant without the word “potential”
> for this issue.
> https://cwe.mitre.org/data/definitions/252.html
> 
> Regards,
> Markus
> 

Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list.  I strongly suggest that you not do this anymore.  Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot