linux-kernel - Re: [PATCH] usb: fix error while OF and ACPI all config Y

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025021343-diner-online-45c1@gregkh>
Date: Thu, 13 Feb 2025 10:49:27 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: 412574090@....com
Cc: linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	weiyufeng <weiyufeng@...inos.cn>
Subject: Re: [PATCH] usb: fix error while OF and ACPI all config Y

On Thu, Feb 13, 2025 at 05:15:53PM +0800, 412574090@....com wrote:
> From: weiyufeng <weiyufeng@...inos.cn>
> 
> When both OF and ACPI are configured as Y simultaneously，this may
> cause error while install os with usb disk，while reading data from
> the usb disk, the onboard_ hub driver will reinitialize the
> hub, causing system installation exceptions.
> 
> Signed-off-by: weiyufeng <weiyufeng@...inos.cn>
> ---
>  drivers/usb/misc/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/misc/Kconfig b/drivers/usb/misc/Kconfig
> index 6497c4e81e95..94e75e7adcc1 100644
> --- a/drivers/usb/misc/Kconfig
> +++ b/drivers/usb/misc/Kconfig
> @@ -318,7 +318,7 @@ config BRCM_USB_PINMAP
>  
>  config USB_ONBOARD_DEV
>  	tristate "Onboard USB device support"
> -	depends on OF
> +	depends on OF && !ACPI
>  	help
>  	  Say Y here if you want to support discrete onboard USB devices
>  	  that don't require an additional control bus for initialization,
> -- 
> 2.25.1
> 

What commit id does this fix?

And why did this just show up now?  Also, this feels very odd, why not
fix the driver to work properly here instead of attempting to just not
build it at all?  Building code with OF and ACPI enabled should be
allowed.

thanks,

greg k-h